[fix] OpenResponses: skip empty reasoning block to avoid breaking non-reasoning models#6953
Open
NIK-TIGER-BILL wants to merge 1 commit intoagno-agi:mainfrom
Open
Conversation
…-reasoning models
_set_reasoning_request_param() unconditionally wrote:
base_params['reasoning'] = self.reasoning or {}
This meant every request carried a 'reasoning': {} key even when no reasoning
was configured. Models that don't support reasoning (e.g. Gemini via OpenRouter)
reject such payloads:
Error: reasoning is not supported for model google/gemini-3.1-pro-preview
Fix: build the reasoning dict from self.reasoning + effort/summary overrides,
and only add it to base_params when the result is non-empty.
Closes agno-agi#6945
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_set_reasoning_request_param()inmodels/openai/responses.pyunconditionally sets:This means every request carries
"reasoning": {}even when no reasoning is configured. Models that do not support reasoning (e.g. Gemini 3.1 Pro Preview via OpenRouter) reject such payloads (closes #6945):Fix
Build the reasoning dict from
self.reasoning+ anyreasoning_effort/reasoning_summaryoverrides, then only include it inbase_paramswhen the result is non-empty:Closes #6945