Added the supporter page and updated the navigations #30
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
|
Hi @RajaprabuGaneshan thanks for your PR! The page looks good. I made some inline comments. But I also noticed you might want to double check responsiveness on different screen sizes.
I see some checks are failing here:
Please let me know if you have any questions. Thanks! |
| segmentMsg: "agntcy github clicked", | ||
| segmentOpt: { | ||
| link_label: "Github", | ||
| location: "global header", | ||
| resource_interaction: "Visit GitHub repositoty", | ||
| }, | ||
| }, | ||
| { | ||
| name: "Resources", |
There was a problem hiding this comment.
I don't think the resource page is ready yet. I know this link is in the design file but please confirm with Cindy if we want to hide it in the first release or not (to launch the supporters page).
| @@ -77,7 +101,7 @@ const Navbar = () => { | |||
| // resource_interaction: "email signup", | |||
| // }} | |||
| > | |||
| <div className="flex-shrink-0 text-xl font-bold text-[#FBAB2C] hover:text-[#00142B] transition ease-in-out hover:bg-[#FBAB2C] border-2 border-[#FBAB2C] py-3 px-5 rounded-full"> | |||
| <div className="flex-shrink-0 text-center text-xl font-bold text-[#FBAB2C] hover:text-[#00142B] transition ease-in-out hover:bg-[#FBAB2C] border-2 border-[#FBAB2C] py-3 md:py-0 lg:py-3 xl:py-3 2xl:py-3 px-5 rounded-full"> | |||
There was a problem hiding this comment.
lg:py-3 xl:py-3 2xl:py-3 looks a little repetitive here to me. The UI should look the same if you remove xl:py-3 2xl:py-3 since they have the same value(py-3).
| "use client"; | ||
| import React, { useEffect, useState } from "react"; | ||
| import "~/styles/form.css"; | ||
| import { analytics } from "lib/segment"; |
There was a problem hiding this comment.
Although we have segment in the codebase. We are not ready to enable it yet since we are still waiting for the site to be on boarded with OneTrust Cookies Consent manager. I have submitted the request on March 31st. Hopefully I will hear back from them this week. But until we have a cookie consent manager enabled, let's disable segment for GDPR compliance.
| <HubspotContactForm | ||
| region="na1" | ||
| portalId="19886599" | ||
| conversion_id='15706732' |
There was a problem hiding this comment.
This conversion_id is tied to the shift newsletter submission form. I don't know if the team want to track conversion on linkedIn for this form or not. We can either remove this conversion_id or ask the team to create a new linkedIn conversion ID for it. Please don't use 15706732 since this goes to a different form.
| export default function Home() { | ||
| return ( | ||
| <div className="min-h-[calc(100vh-100px)] flex items-center justify-center"> | ||
| <Hero /> |
There was a problem hiding this comment.
I know this page is a placeholder right now. Let's make sure we don't push it live until it is ready.
Description
Added the new webpage for supporters and updated the navigations.
Type of Change
Checklist