Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split taskfiles by components #49

Conversation

arpad-csepi
Copy link
Member

This PR is contains modifications of existing taskfiles to make them compontent scoped, fixed some bugs in it and creates new taskfiles to expose these component level tasks to the repository root.

@arpad-csepi arpad-csepi force-pushed the refactor/split-taskfiles-by-components branch 6 times, most recently from 2b4916e to 616fff0 Compare April 7, 2025 13:37
@arpad-csepi arpad-csepi marked this pull request as ready for review April 7, 2025 13:41
@arpad-csepi arpad-csepi requested a review from a team as a code owner April 7, 2025 13:41
@arpad-csepi arpad-csepi force-pushed the refactor/split-taskfiles-by-components branch 5 times, most recently from dc69574 to 22e0a10 Compare April 7, 2025 14:56
This commit contains modifications to the existing taskfiles and creates
new one as well. The modifications are the followings:
- Remove forced current working directory in samples apps
- Mark unused tasks as internal
- Fix some bugs
- Create some checks

The new taskfiles is for organizing all of the tasks into the repo root
main taskfile, so tasks can be called from everywhere.

Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Árpád Csepi <[email protected]>
@arpad-csepi arpad-csepi force-pushed the refactor/split-taskfiles-by-components branch 4 times, most recently from ed4f67b to a089dfe Compare April 7, 2025 16:09
@arpad-csepi arpad-csepi changed the base branch from main to refactor/improve-reusability-of-csit April 8, 2025 07:16
@arpad-csepi arpad-csepi force-pushed the refactor/split-taskfiles-by-components branch from a089dfe to 5ed72d9 Compare April 8, 2025 07:31
@arpad-csepi arpad-csepi merged commit b3a4750 into refactor/improve-reusability-of-csit Apr 8, 2025
12 checks passed
arpad-csepi added a commit that referenced this pull request Apr 8, 2025
* refactor: split taskfiles by components

This commit contains modifications to the existing taskfiles and creates
new one as well. The modifications are the followings:
- Remove forced current working directory in samples apps
- Mark unused tasks as internal
- Fix some bugs
- Create some checks

The new taskfiles is for organizing all of the tasks into the repo root
main taskfile, so tasks can be called from everywhere.

Signed-off-by: Árpád Csepi <[email protected]>

* ci: use new taskfile structure

Signed-off-by: Árpád Csepi <[email protected]>

* fix: change all taskfile extension to .yml

Signed-off-by: Árpád Csepi <[email protected]>

* ci: fix detect changes in samples

Signed-off-by: Árpád Csepi <[email protected]>

* fix(samples): call task without subshell

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): enable workflow run on PR and main merge

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): fix kind version on alt trigger

Signed-off-by: Árpád Csepi <[email protected]>

---------

Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi added a commit that referenced this pull request Apr 8, 2025
* refactor: split taskfiles by components

This commit contains modifications to the existing taskfiles and creates
new one as well. The modifications are the followings:
- Remove forced current working directory in samples apps
- Mark unused tasks as internal
- Fix some bugs
- Create some checks

The new taskfiles is for organizing all of the tasks into the repo root
main taskfile, so tasks can be called from everywhere.

Signed-off-by: Árpád Csepi <[email protected]>

* ci: use new taskfile structure

Signed-off-by: Árpád Csepi <[email protected]>

* fix: change all taskfile extension to .yml

Signed-off-by: Árpád Csepi <[email protected]>

* ci: fix detect changes in samples

Signed-off-by: Árpád Csepi <[email protected]>

* fix(samples): call task without subshell

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): enable workflow run on PR and main merge

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): fix kind version on alt trigger

Signed-off-by: Árpád Csepi <[email protected]>

---------

Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi added a commit that referenced this pull request Apr 8, 2025
* refactor: split taskfiles by components

This commit contains modifications to the existing taskfiles and creates
new one as well. The modifications are the followings:
- Remove forced current working directory in samples apps
- Mark unused tasks as internal
- Fix some bugs
- Create some checks

The new taskfiles is for organizing all of the tasks into the repo root
main taskfile, so tasks can be called from everywhere.

Signed-off-by: Árpád Csepi <[email protected]>

* ci: use new taskfile structure

Signed-off-by: Árpád Csepi <[email protected]>

* fix: change all taskfile extension to .yml

Signed-off-by: Árpád Csepi <[email protected]>

* ci: fix detect changes in samples

Signed-off-by: Árpád Csepi <[email protected]>

* fix(samples): call task without subshell

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): enable workflow run on PR and main merge

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): fix kind version on alt trigger

Signed-off-by: Árpád Csepi <[email protected]>

---------

Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi added a commit that referenced this pull request Apr 10, 2025
* refactor: split taskfiles by components

This commit contains modifications to the existing taskfiles and creates
new one as well. The modifications are the followings:
- Remove forced current working directory in samples apps
- Mark unused tasks as internal
- Fix some bugs
- Create some checks

The new taskfiles is for organizing all of the tasks into the repo root
main taskfile, so tasks can be called from everywhere.

Signed-off-by: Árpád Csepi <[email protected]>

* ci: use new taskfile structure

Signed-off-by: Árpád Csepi <[email protected]>

* fix: change all taskfile extension to .yml

Signed-off-by: Árpád Csepi <[email protected]>

* ci: fix detect changes in samples

Signed-off-by: Árpád Csepi <[email protected]>

* fix(samples): call task without subshell

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): enable workflow run on PR and main merge

Signed-off-by: Árpád Csepi <[email protected]>

* ci(integrations): fix kind version on alt trigger

Signed-off-by: Árpád Csepi <[email protected]>

---------

Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi added a commit that referenced this pull request Apr 11, 2025
* Split taskfiles by components (#49)

* Reusable GitHub action for deploy components (#50)

* GitHub Action workflow_dispatch support (#54)

* ci(integrations): remove trigger from test CI workflow

* Remove embedded helm charts (#57)

* ci: run GW test on latest ubuntu

* chore: add missing default tasks

* fix(integrations): change default dirctl bin path

* fix: exclude default task for better autocompletion

* fix(integrations): solve var collision & remove hardcoded url

* fix(integrations): replace fix path to dirctl bin path

* chore(integrations): update readme task commands
---------

Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Peter Balogh <[email protected]>
Co-authored-by: Peter Balogh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant