-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split taskfiles by components #49
Merged
arpad-csepi
merged 7 commits into
refactor/improve-reusability-of-csit
from
refactor/split-taskfiles-by-components
Apr 8, 2025
Merged
Split taskfiles by components #49
arpad-csepi
merged 7 commits into
refactor/improve-reusability-of-csit
from
refactor/split-taskfiles-by-components
Apr 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b4916e
to
616fff0
Compare
dc69574
to
22e0a10
Compare
This commit contains modifications to the existing taskfiles and creates new one as well. The modifications are the followings: - Remove forced current working directory in samples apps - Mark unused tasks as internal - Fix some bugs - Create some checks The new taskfiles is for organizing all of the tasks into the repo root main taskfile, so tasks can be called from everywhere. Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Árpád Csepi <[email protected]>
Signed-off-by: Árpád Csepi <[email protected]>
ed4f67b
to
a089dfe
Compare
Signed-off-by: Árpád Csepi <[email protected]>
a089dfe
to
5ed72d9
Compare
b3a4750
into
refactor/improve-reusability-of-csit
12 checks passed
arpad-csepi
added a commit
that referenced
this pull request
Apr 8, 2025
* refactor: split taskfiles by components This commit contains modifications to the existing taskfiles and creates new one as well. The modifications are the followings: - Remove forced current working directory in samples apps - Mark unused tasks as internal - Fix some bugs - Create some checks The new taskfiles is for organizing all of the tasks into the repo root main taskfile, so tasks can be called from everywhere. Signed-off-by: Árpád Csepi <[email protected]> * ci: use new taskfile structure Signed-off-by: Árpád Csepi <[email protected]> * fix: change all taskfile extension to .yml Signed-off-by: Árpád Csepi <[email protected]> * ci: fix detect changes in samples Signed-off-by: Árpád Csepi <[email protected]> * fix(samples): call task without subshell Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): enable workflow run on PR and main merge Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): fix kind version on alt trigger Signed-off-by: Árpád Csepi <[email protected]> --------- Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi
added a commit
that referenced
this pull request
Apr 8, 2025
* refactor: split taskfiles by components This commit contains modifications to the existing taskfiles and creates new one as well. The modifications are the followings: - Remove forced current working directory in samples apps - Mark unused tasks as internal - Fix some bugs - Create some checks The new taskfiles is for organizing all of the tasks into the repo root main taskfile, so tasks can be called from everywhere. Signed-off-by: Árpád Csepi <[email protected]> * ci: use new taskfile structure Signed-off-by: Árpád Csepi <[email protected]> * fix: change all taskfile extension to .yml Signed-off-by: Árpád Csepi <[email protected]> * ci: fix detect changes in samples Signed-off-by: Árpád Csepi <[email protected]> * fix(samples): call task without subshell Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): enable workflow run on PR and main merge Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): fix kind version on alt trigger Signed-off-by: Árpád Csepi <[email protected]> --------- Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi
added a commit
that referenced
this pull request
Apr 8, 2025
* refactor: split taskfiles by components This commit contains modifications to the existing taskfiles and creates new one as well. The modifications are the followings: - Remove forced current working directory in samples apps - Mark unused tasks as internal - Fix some bugs - Create some checks The new taskfiles is for organizing all of the tasks into the repo root main taskfile, so tasks can be called from everywhere. Signed-off-by: Árpád Csepi <[email protected]> * ci: use new taskfile structure Signed-off-by: Árpád Csepi <[email protected]> * fix: change all taskfile extension to .yml Signed-off-by: Árpád Csepi <[email protected]> * ci: fix detect changes in samples Signed-off-by: Árpád Csepi <[email protected]> * fix(samples): call task without subshell Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): enable workflow run on PR and main merge Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): fix kind version on alt trigger Signed-off-by: Árpád Csepi <[email protected]> --------- Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi
added a commit
that referenced
this pull request
Apr 10, 2025
* refactor: split taskfiles by components This commit contains modifications to the existing taskfiles and creates new one as well. The modifications are the followings: - Remove forced current working directory in samples apps - Mark unused tasks as internal - Fix some bugs - Create some checks The new taskfiles is for organizing all of the tasks into the repo root main taskfile, so tasks can be called from everywhere. Signed-off-by: Árpád Csepi <[email protected]> * ci: use new taskfile structure Signed-off-by: Árpád Csepi <[email protected]> * fix: change all taskfile extension to .yml Signed-off-by: Árpád Csepi <[email protected]> * ci: fix detect changes in samples Signed-off-by: Árpád Csepi <[email protected]> * fix(samples): call task without subshell Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): enable workflow run on PR and main merge Signed-off-by: Árpád Csepi <[email protected]> * ci(integrations): fix kind version on alt trigger Signed-off-by: Árpád Csepi <[email protected]> --------- Signed-off-by: Árpád Csepi <[email protected]>
arpad-csepi
added a commit
that referenced
this pull request
Apr 11, 2025
* Split taskfiles by components (#49) * Reusable GitHub action for deploy components (#50) * GitHub Action workflow_dispatch support (#54) * ci(integrations): remove trigger from test CI workflow * Remove embedded helm charts (#57) * ci: run GW test on latest ubuntu * chore: add missing default tasks * fix(integrations): change default dirctl bin path * fix: exclude default task for better autocompletion * fix(integrations): solve var collision & remove hardcoded url * fix(integrations): replace fix path to dirctl bin path * chore(integrations): update readme task commands --------- Signed-off-by: Árpád Csepi <[email protected]> Signed-off-by: Peter Balogh <[email protected]> Co-authored-by: Peter Balogh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is contains modifications of existing taskfiles to make them compontent scoped, fixed some bugs in it and creates new taskfiles to expose these component level tasks to the repository root.