Skip to content

Conversation

@arpad-csepi
Copy link
Member

No description provided.

@arpad-csepi arpad-csepi requested a review from a team as a code owner November 13, 2025 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped⏩ skipped✅ passedNov 19, 2025, 2:12 PM

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-49 lines label Nov 13, 2025
@ramizpolic
Copy link
Member

@arpad-csepi do you know why the CI pipelien doesnt run when github-bot opens a PR? This is a separate issue, but the pipeline never runs and we have to recreate the PR under personal name for CI to run

@arpad-csepi
Copy link
Member Author

@arpad-csepi do you know why the CI pipelien doesnt run when github-bot opens a PR? This is a separate issue, but the pipeline never runs and we have to recreate the PR under personal name for CI to run

We are opening the PR with the CI using the GITHUB_TOKEN and this behavior is expected to avoid cilcular CI calls.
I modified the brew workflow to only open a PR if the brew test passes. Do we need to run the CI to be able to merge the brew changes? The other tests in the CI are not useful for these hash changes.

Source: https://github.com/marketplace/actions/add-commit#the-commit-from-the-action-is-not-triggering-ci

@arpad-csepi arpad-csepi force-pushed the ci/fix-brew-download-assets branch 2 times, most recently from bcd8b0b to d05509f Compare November 17, 2025 08:43
@arpad-csepi arpad-csepi linked an issue Nov 17, 2025 that may be closed by this pull request
2 tasks
@arpad-csepi arpad-csepi force-pushed the ci/fix-brew-download-assets branch 6 times, most recently from b8e4235 to f6a00b0 Compare November 17, 2025 18:27
@arpad-csepi
Copy link
Member Author

arpad-csepi commented Nov 17, 2025

@arpad-csepi do you know why the CI pipelien doesnt run when github-bot opens a PR? This is a separate issue, but the pipeline never runs and we have to recreate the PR under personal name for CI to run

We are opening the PR with the CI using the GITHUB_TOKEN and this behavior is expected to avoid cilcular CI calls. I modified the brew workflow to only open a PR if the brew test passes. Do we need to run the CI to be able to merge the brew changes? The other tests in the CI are not useful for these hash changes.

Source: https://github.com/marketplace/actions/add-commit#the-commit-from-the-action-is-not-triggering-ci

Managed to find a workaround to use PAT token as GTIHUB_TOKEN for the CI by closing the reopening the brew update PR by hand. In this way the CI is triggered and the we are able to merge the changes as the Status check will be success.
Added a disclaimer to the automated PR description as a guidence. WDYT @ramizpolic , is it acceptable solution? The other solution can be to create an org account and use that account PAT token for commits.

@ramizpolic
Copy link
Member

@arpad-csepi We have a couple of org-wide accounts that we can use here to bump the version. WDYT if we use a new GH_PR_TOKEN for creating PRs? This way, when we fork the repo, we can also create this secret to make it work.

Can you confirm that, if we use a custom account with GH_PR_TOKEN, once the brew update PR is created, the pipeline will run?

@arpad-csepi arpad-csepi force-pushed the ci/fix-brew-download-assets branch 2 times, most recently from 7015f88 to 4c03df3 Compare November 19, 2025 08:41
@arpad-csepi arpad-csepi force-pushed the ci/fix-brew-download-assets branch from 4c03df3 to 749eb48 Compare November 19, 2025 09:11
@arpad-csepi
Copy link
Member Author

@arpad-csepi We have a couple of org-wide accounts that we can use here to bump the version. WDYT if we use a new GH_PR_TOKEN for creating PRs? This way, when we fork the repo, we can also create this secret to make it work.

Can you confirm that, if we use a custom account with GH_PR_TOKEN, once the brew update PR is created, the pipeline will run?

Confirmed that a custom account can be used with its own token to open a PR and trigger the CI workflow automatically.

@arpad-csepi arpad-csepi enabled auto-merge (squash) November 19, 2025 14:16
@arpad-csepi arpad-csepi merged commit 1cfed3a into main Nov 19, 2025
26 of 27 checks passed
@arpad-csepi arpad-csepi deleted the ci/fix-brew-download-assets branch November 19, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-49 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brew updater reusable workflow fails on release

3 participants