Skip to content

feat: add CLI support for Agent Hub #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Apr 23, 2025
Merged

feat: add CLI support for Agent Hub #82

merged 48 commits into from
Apr 23, 2025

Conversation

matewolf
Copy link
Contributor

@matewolf matewolf commented Apr 2, 2025

No description provided.

@matewolf matewolf force-pushed the hub-cli branch 2 times, most recently from 6247ab4 to 8b99231 Compare April 3, 2025 14:18
@paralta paralta changed the title Add CLI support for Agent Hub feat: add CLI support for Agent Hub Apr 3, 2025
@matewolf matewolf force-pushed the hub-cli branch 2 times, most recently from be296f0 to fcd0ecd Compare April 3, 2025 14:43
@paralta
Copy link
Member

paralta commented Apr 3, 2025 •
edited
Loading

@matewolf As discussed, I think we could improve the PR with the following suggestions:

  • Keep all API code under the /api folder by moving /hub/api to /api/hub/
  • Review if the proto messages that already exist in api/core can be reused by the hub like Locator, Category (category has been deprecated in favour of Skill) and Agent
  • Keep options for each command inside the corresponding command folder

@matewolf matewolf force-pushed the hub-cli branch 2 times, most recently from 1c35845 to db6fb79 Compare April 4, 2025 16:22
@matewolf matewolf marked this pull request as ready for review April 4, 2025 16:23
@matewolf matewolf requested a review from a team as a code owner April 4, 2025 16:23
paralta
paralta reviewed Apr 7, 2025
View reviewed changes
paralta
paralta reviewed Apr 7, 2025
View reviewed changes
paralta
paralta reviewed Apr 7, 2025
View reviewed changes
tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@tkircsi tkircsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is big, so it makes sense to add my reviews step by step. I continue my review.

tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
tkircsi
tkircsi reviewed Apr 7, 2025
View reviewed changes
@matewolf matewolf force-pushed the hub-cli branch 2 times, most recently from 729a84d to e03290d Compare April 15, 2025 16:17
paralta
paralta reviewed Apr 16, 2025
View reviewed changes
paralta
paralta reviewed Apr 16, 2025
View reviewed changes
cli/cmd/options.go Outdated
flags := RootCmd.PersistentFlags()
flags.StringVar(&clientConfig.ServerAddress, "server-addr", clientConfig.ServerAddress, "Directory Server API address")

RootCmd.MarkFlagRequired("server-addr") //nolint:errcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where was this code moved to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this because it was not used according to my ide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it back.

cli/hub/client/hub/client.go Outdated
// Copyright AGNTCY Contributors (https://github.com/agntcy)
// SPDX-License-Identifier: Apache-2.0

package hub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the api code comment, maybe the client code should be moved to the client directory?

We can initiate a discussion on this topic, because if the hub code should be independent from the rest, it probably needs a new hub folder at root instead of a folder inside the cli folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is the same I mentioned above.

matewolf added 4 commits April 22, 2025 17:18
@matewolf
Add login command
b1b2220 
Signed-off-by: matewolf <[email protected]>
@matewolf
Add logout command
a75d13a 
Signed-off-by: matewolf <[email protected]>
@matewolf
Add logout command
f95c55e 
Signed-off-by: matewolf <[email protected]>
@matewolf
Add push and pull agent command
d0a57c1 
Signed-off-by: matewolf <[email protected]>
matewolf added 24 commits April 22, 2025 17:20
@matewolf
move options close to commands
5ac545f 
Signed-off-by: matewolf <[email protected]>
@matewolf
remove version from hub push and pull command
8e7a922 
Signed-off-by: matewolf <[email protected]>
@matewolf
add extra check for switching tenant flow
f382b28 
Signed-off-by: matewolf <[email protected]>
@matewolf
remove setting authconfig nil in hub
7edacdd 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix linter errors
efed26a 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix linter errors
75e21e7 
Signed-off-by: matewolf <[email protected]>
@matewolf
resolve rebase conflicts
5f0c979 
Signed-off-by: matewolf <[email protected]>
@matewolf
remove incorrect formatting of descriptions
98defa1 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix linter erros
42304c3 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix unhandled flags when comes from viper
f7e5ce1 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix unhandled flags when comes from viper
0139b88 
Signed-off-by: matewolf <[email protected]>
@matewolf
update local webserver port
f7b8e2e 
Signed-off-by: matewolf <[email protected]>
@matewolf
remove duplicated commands
bbe8529 
Signed-off-by: matewolf <[email protected]>
@matewolf
update hub interface
a7ee21a 
Signed-off-by: matewolf <[email protected]>
@matewolf
revert refactor and place hub command to separate module
b778c39 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix linter errors
b695940 
Signed-off-by: matewolf <[email protected]>
@matewolf
remove hub api
9f07e47 
Signed-off-by: matewolf <[email protected]>
@matewolf
remove exclude line
bf0c123 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix linter errors
beeedf5 
Signed-off-by: matewolf <[email protected]>
@matewolf
form stderr and stdout output
57296da 
Signed-off-by: matewolf <[email protected]>
@matewolf
move hub to a separate module and resolve comments
5c1c94f 
Signed-off-by: matewolf <[email protected]>
@matewolf
restore unused file
32d5005 
Signed-off-by: matewolf <[email protected]>
@matewolf
add go.mod and go.sum of hub
50ce9a9 
Signed-off-by: matewolf <[email protected]>
@matewolf
fix linter issues
0026fbc 
Signed-off-by: matewolf <[email protected]>
@adamtagscherer adamtagscherer added the enhancement New feature or request label Apr 23, 2025
adamtagscherer
adamtagscherer approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@adamtagscherer adamtagscherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on discussions with @matewolf and @rappizs, this PR can be merged after numerous reviews from @paralta and @ramizpolic
any further improvements will be added in a follow up PR
code under hub needs to be moved to it's separate repository

@matewolf matewolf merged commit ea6d693 into main Apr 23, 2025
14 checks passed
@matewolf matewolf deleted the hub-cli branch April 23, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkircsi tkircsi tkircsi left review comments

@paralta paralta paralta left review comments

@adamtagscherer adamtagscherer adamtagscherer approved these changes

Assignees

@matewolf matewolf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matewolf @paralta @adamtagscherer @tkircsi