Skip to content

Conversation

@ramizpolic
Copy link
Member

This PR resolves #69 and #105 rebase issues

Co-authored-by: Mauro Sardara <[email protected]>
Co-authored-by: Aron Kerekes <[email protected]>
Signed-off-by: Ramiz Polic <[email protected]>
@ramizpolic ramizpolic requested a review from a team as a code owner June 12, 2025 13:55
@ramizpolic ramizpolic requested review from jubarbot-cisco and removed request for a team June 12, 2025 13:55
Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @msardara, @keraron and @ramizpolic!

@ramizpolic
Copy link
Member Author

all the credit goes to @msardara for starting this and @keraron for pushing the content to the end

@msardara msardara changed the title feat: switch to mcdocs theme feat: switch to mkdocs theme Jun 12, 2025
@ramizpolic ramizpolic changed the title feat: switch to mkdocs theme feat: switch to mkdocs theme (#69, #105) Jun 12, 2025
Signed-off-by: Ramiz Polic <[email protected]>
Signed-off-by: Ramiz Polic <[email protected]>
@ramizpolic ramizpolic removed the request for review from jubarbot-cisco June 12, 2025 14:30
Copy link
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document structure needs to revised.

Copy link
Contributor

@jodeev jodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some quick fixes that will make measurable improvements to the directory docs. If not for this PR, they should go in an upcoming PR.

Signed-off-by: Luca Muscariello <[email protected]>
Signed-off-by: Luca Muscariello <[email protected]>
Signed-off-by: Luca Muscariello <[email protected]>
Signed-off-by: Luca Muscariello <[email protected]>
Signed-off-by: Luca Muscariello <[email protected]>
Copy link
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants