feat: Add path config on Secrets Manager prefix for Keys#12
Merged
Conversation
Signed-off-by: jdiaconu <jdiaconu@cisco.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable path prefix support for AWS Secrets Manager across both credential and key storage services. The change enables customization of the secrets path hierarchy in AWS Secrets Manager.
- Changed
secretsPrefixparameter from pointer to string type for consistency - Added
secretsPrefixparameter toNewAwsSmKeyStorefunction - Updated function calls to pass the secrets prefix configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/internal/core/idp/credential_aws_sm.go | Changed secretsPrefix from pointer to string type and updated usage |
| backend/internal/core/identity/key.go | Added secretsPrefix parameter to NewAwsSmKeyStore function |
| backend/cmd/bff/main.go | Updated function calls to pass secretsPrefix without pointer reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add prefix for AWS Secret Manager + Keys.
Type of Change
Checklist