Skip to content

feat: Add path config on Secrets Manager prefix for Keys#12

Merged
jadiaconu merged 1 commit into
mainfrom
feat/add-config-for-secrets-entry
Sep 23, 2025
Merged

feat: Add path config on Secrets Manager prefix for Keys#12
jadiaconu merged 1 commit into
mainfrom
feat/add-config-for-secrets-entry

Conversation

@jadiaconu

Copy link
Copy Markdown
Collaborator

Description

Add prefix for AWS Secret Manager + Keys.

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Signed-off-by: jdiaconu <jdiaconu@cisco.com>
Copilot AI review requested due to automatic review settings September 23, 2025 09:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable path prefix support for AWS Secrets Manager across both credential and key storage services. The change enables customization of the secrets path hierarchy in AWS Secrets Manager.

  • Changed secretsPrefix parameter from pointer to string type for consistency
  • Added secretsPrefix parameter to NewAwsSmKeyStore function
  • Updated function calls to pass the secrets prefix configuration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
backend/internal/core/idp/credential_aws_sm.go Changed secretsPrefix from pointer to string type and updated usage
backend/internal/core/identity/key.go Added secretsPrefix parameter to NewAwsSmKeyStore function
backend/cmd/bff/main.go Updated function calls to pass secretsPrefix without pointer reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jadiaconu jadiaconu merged commit ef4a364 into main Sep 23, 2025
7 of 8 checks passed
@jadiaconu jadiaconu deleted the feat/add-config-for-secrets-entry branch September 23, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants