Feat/add ping idp provider by jadiaconu · Pull Request #151 · agntcy/identity-service

jadiaconu · 2026-01-13T15:58:28Z

Description

Add Ping Identity as an IdP.

Type of Change

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass

github-actions · 2026-01-13T15:58:49Z

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see actions/dependency-review-action/issues/938.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

Pull request overview

This pull request adds Ping Identity (PingOne) as a new Identity Provider (IdP) option to the identity service. The implementation includes backend API changes via protobuf definitions, Go implementation with HTTP client integration for PingOne APIs, frontend UI components for configuration, comprehensive test coverage, and documentation.

Changes:

Added IDP_TYPE_PING enum value and PingIdpSettings message to protocol buffers
Implemented PingIdp struct in Go with methods for testing settings, creating/deleting client credentials
Added frontend form inputs, validation schemas, UI components, and Ping Identity logo
Included comprehensive unit tests for backend implementation and frontend schema validation
Added detailed documentation for configuring Ping Identity as an IdP

Reviewed changes

Copilot reviewed 55 out of 58 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`backend/api/spec/proto/agntcy/identity/service/v1alpha1/settings.proto`	Added PingIdpSettings message and IDP_TYPE_PING enum value
`backend/internal/core/idp/ping_idp.go`	Core implementation of Ping Identity provider with OAuth2 client credentials flow
`backend/internal/core/idp/ping_idp_test.go`	Comprehensive unit tests for Ping IdP implementation
`backend/internal/core/idp/idp_factory.go`	Registered Ping IdP in factory pattern
`backend/internal/core/settings/types/types.go`	Added PingIdpSettings type and IDP_TYPE_PING constant
`backend/internal/core/settings/postgres/models.go`	Database models for persisting Ping IdP settings with encryption
`frontend/src/schemas/identity-provider-schema.ts`	Validation schema for Ping IdP configuration fields
`frontend/src/components/identity-provider/create/form/identity-provider-form.tsx`	Form UI for Ping IdP configuration
`frontend/src/assets/ping.svg`	Ping Identity logo asset
`docs/docs/idp.md`	Documentation for Ping Identity setup and configuration
`scripts/proto/docker/Dockerfile.buf`	Updated Go version in Docker build

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 54 out of 57 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 56 out of 59 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

Copilot

Pull request overview

Copilot reviewed 56 out of 59 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-20T14:09:17Z

+	if settings != nil && settings.Region != "" &&
+		strings.Contains(pingRegions, settings.Region) {
+		region = settings.Region


The region validation using strings.Contains is unsafe. For example, the input "comeup" would incorrectly match because it contains "com", or "eu" would match against "com.au". Use a proper validation approach with an exact match against allowed regions.

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

Copilot

Pull request overview

Copilot reviewed 56 out of 58 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 56 out of 58 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rafaelsilva29

LGTM!

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

Copilot AI review requested due to automatic review settings January 13, 2026 15:58

jadiaconu requested review from beryder, copasseron, hmuyal, mayannuz, mkedjour and rafaelsilva29 as code owners January 13, 2026 15:58

Copilot started reviewing on behalf of jadiaconu January 13, 2026 15:58 View session

jadiaconu marked this pull request as draft January 13, 2026 16:01

Copilot AI reviewed Jan 13, 2026

View reviewed changes

jadiaconu force-pushed the feat/add-ping-idp-provider branch from cc0f7fe to 84803f4 Compare January 14, 2026 12:43

Copilot AI review requested due to automatic review settings January 14, 2026 12:43

Copilot started reviewing on behalf of jadiaconu January 14, 2026 12:43 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 15, 2026 09:05

Copilot started reviewing on behalf of jadiaconu January 15, 2026 09:05 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Comment thread backend/internal/core/idp/ping_idp.go

jadiaconu added 8 commits January 20, 2026 14:43

feat: Add implementation for backend

efd7a41

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Add implementation for frontend

c9d6641

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Add implementation for docs

228000e

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Gen specs

b362209

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

chore: Remove binary

cec34a8

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Add converters

adde2cc

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Restrict to eu, com

652e658

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Support other regions

ced2b53

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

jadiaconu force-pushed the feat/add-ping-idp-provider branch from 367539c to ced2b53 Compare January 20, 2026 14:02

Copilot AI review requested due to automatic review settings January 20, 2026 14:02

Copilot started reviewing on behalf of jadiaconu January 20, 2026 14:03 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

jadiaconu added 2 commits January 20, 2026 15:21

fix: Fix region testing

d2c51fa

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

chore: Remove white space

39fb3d1

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

Copilot AI review requested due to automatic review settings January 20, 2026 14:26

Copilot started reviewing on behalf of jadiaconu January 20, 2026 14:27 View session

jadiaconu marked this pull request as ready for review January 20, 2026 14:27

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Comment thread docs/docs/idp.md Outdated

Comment thread backend/internal/core/idp/ping_idp.go

jadiaconu requested a review from Copilot January 21, 2026 09:38

Copilot started reviewing on behalf of jadiaconu January 21, 2026 09:38 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Comment thread backend/internal/core/idp/ping_idp.go

mkedjour reviewed Jan 22, 2026

View reviewed changes

Comment thread backend/internal/bff/settings_service.go

agntcy deleted a comment from Copilot AI Jan 22, 2026

rafaelsilva29 approved these changes Jan 22, 2026

View reviewed changes

jadiaconu added 5 commits January 23, 2026 10:47

fix: Fix settings for Ping

6dd4bb5

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Fix json inefficiency

89adc6d

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

docs: Fix docs for regions in Ping

7fa6088

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

feat: Add test for Ping

2a4ca2f

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

docs: Update formatting

d43fb89

Signed-off-by: jdiaconu <jdiaconu@cisco.com>

jadiaconu merged commit 0368c48 into main Jan 26, 2026
8 of 9 checks passed

jadiaconu deleted the feat/add-ping-idp-provider branch January 26, 2026 09:30

jadiaconu moved this to Done in AGNTCY Project Jan 29, 2026

jadiaconu added this to AGNTCY Project Jan 29, 2026

jadiaconu moved this from Done to Pending review in AGNTCY Project Jan 29, 2026

jadiaconu moved this from Pending review to Done in AGNTCY Project Jan 29, 2026

Uh oh!

Conversation

jadiaconu commented Jan 13, 2026

Description

Type of Change

Checklist

Uh oh!

github-actions Bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

rafaelsilva29 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jan 13, 2026 •

edited

Loading