Skip to content

Feat/fix pipelines#9

Merged
jadiaconu merged 2 commits into
mainfrom
feat/fix-pipelines
Sep 23, 2025
Merged

Feat/fix pipelines#9
jadiaconu merged 2 commits into
mainfrom
feat/fix-pipelines

Conversation

@jadiaconu

Copy link
Copy Markdown
Collaborator

Description

Build stuff

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Signed-off-by: jdiaconu <jdiaconu@cisco.com>
Signed-off-by: jdiaconu <jdiaconu@cisco.com>
Copilot AI review requested due to automatic review settings September 23, 2025 08:05
@jadiaconu jadiaconu merged commit ea33c8a into main Sep 23, 2025
7 of 8 checks passed
@jadiaconu jadiaconu deleted the feat/fix-pipelines branch September 23, 2025 08:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes file paths in Docker build configurations and adds a GitHub workflow for Python SDK releases. The changes appear to correct the project structure by adding "samples/" prefix to Docker COPY commands and introduce automated PyPI publishing capabilities.

  • Updated Docker file paths to reflect the current project structure with "samples/" prefix
  • Added GitHub workflow for automated Python SDK releases to PyPI
  • Modified linting configuration to exclude additional directories and disable Python flake8 validation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
samples/mcp/currency_exchange/Dockerfile Updated COPY path to include "samples/" prefix
samples/agent/oasf/financial_assistant/Dockerfile Updated COPY paths to include "samples/" prefix for both main files and UI directory
samples/agent/a2a/currency_exchange/Dockerfile Updated COPY path to include "samples/" prefix
.github/workflows/release-python-sdk.yml Added new workflow for automated PyPI publishing of Python SDK
.github/workflows/lint.yml Extended regex exclusions and disabled Python flake8 validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

uses: pypa/gh-action-pypi-publish@release/v1
with:
packages-dir: ./python/dist
password: ${{ secrets.PYPI_API_TOKEN }}

Copilot AI Sep 23, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using password-based authentication with PYPI_API_TOKEN is deprecated. Since Trusted Publishing is already configured (id-token: write permission), remove the password parameter to use the more secure OIDC-based authentication method.

Suggested change
password: ${{ secrets.PYPI_API_TOKEN }}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants