feat: schema package to return structured taxonomy#147
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
akijakya
force-pushed
the
feat/schema-package-return-structured-taxonomy
branch
from
e919026 to
f0d9480
Compare
adamtagscherer
approved these changes
Apr 1, 2026
Member
adamtagscherer
left a comment
adamtagscherer
left a comment
There was a problem hiding this comment.
Could we use Redis instead of implementing ~x hundred lines of cache in go? Otherwise LGTM
Member
Author
I think using an extra service would be an overkill for this use case, and we wouldn't benefit as much from a persistent cache... |
akijakya
force-pushed
the
feat/schema-package-return-structured-taxonomy
branch
2 times, most recently
from
a3a4073 to
0b6b94f
Compare
ramizpolic
reviewed
Apr 1, 2026
ramizpolic
reviewed
Apr 1, 2026
ramizpolic
reviewed
Apr 1, 2026
akijakya
force-pushed
the
feat/schema-package-return-structured-taxonomy
branch
4 times, most recently
from
3cb1695 to
ab142b4
Compare
ramizpolic
reviewed
Apr 2, 2026
ramizpolic
approved these changes
Apr 2, 2026
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
Signed-off-by: András Jáky <ajaky@cisco.com>
akijakya
force-pushed
the
feat/schema-package-return-structured-taxonomy
branch
from
ab142b4 to
6bbaff3
Compare
since there will be no caching implemented when used via the server yet Signed-off-by: András Jáky <ajaky@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
schemapackage GetSchemaSkills etc. now returns Go struct with nested taxonomyschemapackage optionally caches the schema dynamically (only results that has been requested) so as long as it lives, it won't hit the OASF API anymore. The cache can be reloaded as well.Closes #123