Skip to content

ci: publish crates via crates.io Trusted Publishing, not a static token - #208

Merged
muscariello merged 1 commit into
mainfrom
ci/crates-io-trusted-publishing
Sep 4, 2026
Merged

muscariello merged 1 commit into
mainfrom
ci/crates-io-trusted-publishing

Conversation

@muscariello

@muscariello muscariello commented Sep 4, 2026

Copy link
Copy Markdown
Member

crates.io now requires Trusted Publishing for agntcy-shadi-agent-transport-slim, which broke the last release. All 13 published crates are registered as Trusted Publishers now (repo owner confirmed).

release-plz already does the OIDC exchange itself when no CARGO_REGISTRY_TOKEN is set — no new workflow logic needed, just delete the secret and the step that checked for it. agntcy/slim already runs this way on the same release-plz version.

Delete the CARGO_REGISTRY_TOKEN repo secret once a real release confirms this works.

@muscariello
muscariello requested a review from a team as a code owner September 4, 2026 07:51
@muscariello
muscariello requested a review from tkircsi September 4, 2026 07:51
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@muscariello
muscariello force-pushed the ci/crates-io-trusted-publishing branch from 2365b09 to 01bd462 Compare September 4, 2026 08:02
release-plz already exchanges a GitHub Actions OIDC token for a short-lived
crates.io token whenever no CARGO_REGISTRY_TOKEN is set — no flag needed.
All 13 published crates are registered as Trusted Publishers on crates.io
for this repo + release-rust.yml, so the static secret and the step that
checked for it can just go.

agntcy/slim's release-rust.yaml, pinned to the same release-plz/action
commit, already runs this way.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
@muscariello
muscariello force-pushed the ci/crates-io-trusted-publishing branch from 01bd462 to 9d7639f Compare September 4, 2026 08:13
@muscariello
muscariello merged commit 0b7627b into main Sep 4, 2026
17 checks passed
@muscariello
muscariello deleted the ci/crates-io-trusted-publishing branch September 4, 2026 08:52
muscariello added a commit that referenced this pull request Sep 4, 2026
#207 bumped the workspace to 0.1.7 and merged, but its publish run failed on
the Trusted Publishing requirement #208 later fixed. With release_always =
false nothing retried it: release skipped every later push, and release-pr
would not bump past a version crates.io has not seen.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
muscariello added a commit that referenced this pull request Sep 4, 2026
#207 bumped the workspace to 0.1.7 and merged, but its publish run failed on
the Trusted Publishing requirement #208 later fixed. With release_always =
false nothing retried it: release skipped every later push, and release-pr
would not bump past a version crates.io has not seen.

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants