Skip to content

Comments

Support docker deployment#28

Merged
sancyx merged 11 commits intomainfrom
docker-deployment
Apr 6, 2025
Merged

Support docker deployment#28
sancyx merged 11 commits intomainfrom
docker-deployment

Conversation

@sancyx
Copy link
Contributor

@sancyx sancyx commented Apr 2, 2025 •
edited
Loading

Description

  • add manifest to docker image
  • bake all necessary env vars for workflow-manager in docker image except agent ID and API KEY which are always passed upon every deployment

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@github-actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@sancyx sancyx changed the title Improve docker build logs Support docker deployment Apr 2, 2025
@sancyx sancyx force-pushed the docker-deployment branch from 2e5b5ef to 1ea1e79 Compare April 2, 2025 21:02
@sancyx sancyx marked this pull request as ready for review April 3, 2025 13:23
@sancyx sancyx requested a review from a team as a code owner April 3, 2025 13:23
sancyx added 5 commits April 3, 2025 18:25
@sancyx
feat: add env vars to dockerfile
671886f 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
feat: build manifest into the docker image
b7348c7 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
feat: build necessary env vars into the image
ec3f804 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
fix: deployer test
9fcb133 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
feat: add manifest hashcode to image tag
6a9ec57 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx sancyx force-pushed the docker-deployment branch from cf64f47 to 6a9ec57 Compare April 3, 2025 17:00
@sancyx
fix: add start script to docker images
604e060 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx sancyx force-pushed the docker-deployment branch from b341aa0 to 604e060 Compare April 4, 2025 10:14
lpuskas
lpuskas approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@lpuskas lpuskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sancyx sancyx force-pushed the docker-deployment branch from 14fbffa to c609e40 Compare April 4, 2025 12:15
@sancyx
fix: validate invalid deployment option
eeaff71 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx sancyx force-pushed the docker-deployment branch from c609e40 to eeaff71 Compare April 4, 2025 12:44
sancyx added 4 commits April 4, 2025 18:14
@sancyx
fix: remove unnecessary properties from docker deployment in spec
42c8d06 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
fix: test error
e034aba 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
fix: llama framework type
3dcb2c7 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx
feat: add docker deployment example
75ed76d 
Signed-off-by: Magyari Sandor Szilard <sancyx@gmail.com>
@sancyx sancyx merged commit 7dbef39 into main Apr 6, 2025
5 checks passed
@sancyx sancyx deleted the docker-deployment branch April 6, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpuskas lpuskas lpuskas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sancyx @lpuskas