Skip to content

Comments

Support Threads for LG#53

Merged
janosSarusiKis merged 37 commits intomainfrom
puccini-232-threads
Apr 30, 2025
Merged

Support Threads for LG#53
janosSarusiKis merged 37 commits intomainfrom
puccini-232-threads

Conversation

@janosSarusiKis
Copy link
Contributor

@janosSarusiKis janosSarusiKis commented Apr 14, 2025

Description

Support for Threads and Thread Runs endpoints.
https://spec.acp.agntcy.org/docs/openapi.html#tag/threads
https://spec.acp.agntcy.org/docs/openapi.html#tag/thread-runs
Thread:

  • Create Empty
  • Search
  • Get history
  • Copy
  • Get
  • Delete

Thread Runs

  • List
  • Get
  • Get with wait for result
  • Delete
  • Create
  • Create and wait for output

Storage level changes to store thread info.

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@janosSarusiKis janosSarusiKis self-assigned this Apr 14, 2025
janosSarusiKis and others added 2 commits April 14, 2025 16:27
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@github-actions
Copy link

github-actions bot commented Apr 14, 2025

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

poetry.lock

PackageVersionLicenseIssue Type
psycopg3.2.6NullUnknown License
langgraph-checkpoint-postgres2.0.21NullUnknown License
Denied Licenses: AGPL-1.0, AGPL-3.0

OpenSSF Scorecard

PackageVersionScoreDetails
pip/langgraph-checkpoint-postgres 2.0.21 UnknownUnknown
pip/psycopg 3.2.6 UnknownUnknown
pip/psycopg-pool 3.2.6 UnknownUnknown

Scanned Files

  • poetry.lock

Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@janosSarusiKis janosSarusiKis changed the title WIP: Puccini 232 threads Puccini-232 Support Threads for LG Apr 25, 2025
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@janosSarusiKis janosSarusiKis marked this pull request as ready for review April 28, 2025 15:45
@janosSarusiKis janosSarusiKis requested a review from a team as a code owner April 28, 2025 15:45
thread_id: str, limit: int, before: int
) -> Optional[List[ApiThreadState]]:
"""Get the history of a thread"""
## TODO : Update this for multi agent support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we should get agent_info by agent_id coming from the API, but I see this is not there today (not for all calls). I guess that should be fixed in the API Specs @aduminuc ?

Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@janosSarusiKis janosSarusiKis changed the title Puccini-232 Support Threads for LG Support Threads for LG Apr 30, 2025
@janosSarusiKis janosSarusiKis force-pushed the puccini-232-threads branch 2 times, most recently from 33951c9 to 62348bd Compare April 30, 2025 11:07
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@mtrinell mtrinell self-requested a review April 30, 2025 11:17
Copy link
Member

@mtrinell mtrinell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janosSarusiKis janosSarusiKis merged commit 1d650c7 into main Apr 30, 2025
5 checks passed
@janosSarusiKis janosSarusiKis deleted the puccini-232-threads branch April 30, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants