-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Support streaming #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e38f89
to
a73be0f
Compare
Signed-off-by: Jeff Napper <[email protected]>
Signed-off-by: Jeff Napper <[email protected]>
a73be0f
to
33ce664
Compare
Signed-off-by: Jeff Napper <[email protected]>
Signed-off-by: Jeff Napper <[email protected]>
Signed-off-by: Jeff Napper <[email protected]>
Signed-off-by: Jeff Napper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm.
Alongside some minor fixes/comments, unit tests for the new stream_events
function are missing.
Also, I see this only supports values
stream mode, and not custom
. Is this intentional?
Signed-off-by: Jeff Napper <[email protected]>
Yes, and yes. The values mode was tested alongside the client in the interest of time. We will need to add the unit tests and custom support later. I did not have a test agent that sent custom stream events yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the comments above:
- Remove CLI args (not needed imho)
- This PR adds support for
values
stream mode only. StreamMode type is included in RunCreate(Stateless) requests. This should be checked, so in case stream_mode == custom we should trigger a NotImplemented error
Signed-off-by: Jeff Napper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR adds support for SSE streaming of agent value stream events.
Type of Change
Checklist