improving logic around VM launch mutex #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Glenn Hansen <[email protected]>
Signed-off-by: Travis Glenn Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
This attempts to address the issue by using a separate counter for VMs that are allocated to run.
It is possible to have more than 2 Pods submitted for the node (most easily if you simply manually set
nodeNameon the Pod spec). This addresses those scenarios.I'm not familiar enough with the internals of the app to know if the decrement logic is appropriate. Most specifically:
DeleteVirtualMachineis invoked and if that could be overly delayed. For example if the Pod is still in k8s but completed wouldDeleteVirtualMachinebe invoked?vm.Start()fails inDeleteVirtualMachineinvoked? Is it invoked immediately or after some other event triggers it?