feat: Add AI-powered tool system with function calling capabilities by themusicman · Pull Request #3 · agoodway/workie

themusicman · 2025-07-22T22:58:29Z

Overview

This PR introduces a comprehensive tool system that enables AI-powered interactions with system commands and operations through LangChain integration.

✨ Key Features

Tool System: Unified interface for filesystem, git, shell, and AI agent operations
AI Agents: Support for both Ollama and simple agent implementations
Function Calling: LangChain integration for intelligent tool selection and execution
Enhanced Ask Command: AI-powered command suggestions and execution
Comprehensive Tools:
- Filesystem operations (read, write, list directories)
- Git operations (status, add, commit, push, etc.)
- Shell command execution
- Commit message generation

🔧 Technical Changes

New Components

tools/ package with complete tool ecosystem
OllamaAgent and SimpleAgent implementations
Unified Tool interface for consistent tool execution
Advanced commit message generation with AI

Enhanced Commands

ask: Now supports tool integration and AI-powered responses
init: Simplified implementation with better error handling

Configuration Updates

Expanded .workie.yaml with comprehensive tool configuration
Support for multiple AI models and agents

📊 Stats

858b202: Added 998 lines across 11 files (initial tool system)
c595027: Added 484 lines across 4 files (function calling implementation)
Total: 1,482 lines of new functionality

🚨 Breaking Changes

Restructured command interface
Updated configuration format
New dependency requirements

🧪 Usage Examples

# AI-powered git operations
workie ask "create a commit with a good message for these changes"

# Filesystem operations
workie ask "show me the contents of the tools directory"

# Shell command assistance
workie ask "help me check the status of this repository"

Dependencies Added

LangChain Go integration
Enhanced Ollama client support

Ready for review! 🚀

- add tools package with filesystem, git, shell, and agent tools - implement unified tool interface and execution system - add ollama and simple agent implementations for AI interactions - enhance ask command with tool integration - simplify init command implementation - update configuration with expanded tool capabilities - add required dependencies BREAKING CHANGE: restructured command interface and configuration format

…wered system commands

Copilot

Pull Request Overview

This PR introduces a comprehensive AI-powered tool system that enables intelligent interaction with system commands and operations through LangChain integration. The implementation adds function calling capabilities to the existing ask command and provides specialized tools for filesystem, git, shell, and commit message operations.

Key changes include:

Complete tool ecosystem with unified interface for AI-powered operations
Enhanced ask command with tool integration and function calling support
AI agent implementations supporting both Ollama and simplified execution patterns

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tools/tool.go	Core tool interface and registry system with JSON schema support
tools/simple_agent.go	Simplified agent implementation with direct query handling patterns
tools/ollama_agent.go	Full LangChain-integrated agent with conversation management
tools/shell_tool.go	Whitelisted shell command execution tool
tools/git_tool.go	Git operations tool with smart defaults
tools/filesystem_tool.go	File system operations tool with safety controls
tools/commit_message_tool.go	AI-powered commit message generation tool
cmd/ask.go	Enhanced ask command with tool calling capabilities
go.mod	Updated dependencies for LangChain integration
cmd/init.go	Updated configuration template with AI settings
.workie.yaml	Comprehensive configuration with AI and tool settings

Copilot · 2025-07-22T22:59:48Z

+	toolDescriptions := "You are an AI assistant with access to tools that can execute system commands. You have access to the following tools:\n\n"
+
+	for _, tool := range tools {
+		params, _ := json.MarshalIndent(tool.Parameters(), "", "  ")


Error from json.MarshalIndent is silently ignored. This could result in empty or incomplete parameter documentation being shown to users, making it difficult to understand how to use tools properly.

Suggested change

params, _ := json.MarshalIndent(tool.Parameters(), "", " ")

params, err := json.MarshalIndent(tool.Parameters(), "", " ")

if err != nil {

toolDescriptions += "Tool: " + tool.Name() + "\n"

toolDescriptions += "Description: " + tool.Description() + "\n"

toolDescriptions += "Parameters: [Error formatting parameters: " + err.Error() + "]\n\n"

continue

}

Copilot · 2025-07-22T22:59:49Z

+			fmt.Println("Detected list files query, using shell tool directly")
+		}
+
+		tool, _ := s.registry.Get("shell")


Tool retrieval error is ignored. If the shell tool is not registered, this will cause a panic when calling tool.Execute. Should check the exists boolean and handle the error gracefully.

Suggested change

tool, _ := s.registry.Get("shell")

tool, exists := s.registry.Get("shell")

if !exists {

return "", fmt.Errorf("shell tool is not registered in the tool registry")

}

Copilot · 2025-07-22T22:59:49Z

+			fmt.Println("Detected branch query, using git tool directly")
+		}
+
+		tool, _ := s.registry.Get("git")


Tool retrieval error is ignored. If the git tool is not registered, this will cause a panic when calling tool.Execute. Should check the exists boolean and handle the error gracefully.

Suggested change

tool, _ := s.registry.Get("git")

tool, exists := s.registry.Get("git")

if !exists {

return "", fmt.Errorf("the 'git' tool is not registered in the tool registry")

}

Copilot · 2025-07-22T22:59:49Z

+			fmt.Println("Detected pwd query, using shell tool directly")
+		}
+
+		tool, _ := s.registry.Get("shell")


Tool retrieval error is ignored. If the shell tool is not registered, this will cause a panic when calling tool.Execute. Should check the exists boolean and handle the error gracefully.

Suggested change

tool, _ := s.registry.Get("shell")

tool, exists := s.registry.Get("shell")

if !exists {

return "", fmt.Errorf("shell tool is not registered in the tool registry")

}

Copilot · 2025-07-22T22:59:49Z

+
+// generateCommitMessageWithGit uses git tools to analyze changes
+func (s *SimpleAgent) generateCommitMessageWithGit(ctx context.Context) (string, error) {
+	gitTool, _ := s.registry.Get("git")


Tool retrieval error is ignored. If the git tool is not registered, this will cause a panic when calling tool.Execute. Should check the exists boolean and handle the error gracefully.

Suggested change

gitTool, _ := s.registry.Get("git")

gitTool, exists := s.registry.Get("git")

if !exists {

return "", fmt.Errorf("git tool is not registered in the tool registry")

}

Copilot · 2025-07-22T22:59:50Z

+
+	// Clean the path to prevent directory traversal
+	path = filepath.Clean(path)
+


The filepath.Clean() function alone is insufficient to prevent directory traversal attacks. An attacker could still access files outside the intended directory using paths like '../../../etc/passwd'. Consider implementing additional validation to restrict access to a specific base directory.

Suggested change

// Clean the path to prevent directory traversal

path = filepath.Clean(path)

// Define the base directory for file operations

baseDir := "/safe/base/directory"

// Clean the path to prevent directory traversal

path = filepath.Clean(path)

// Ensure the path is within the base directory

if !strings.HasPrefix(path, filepath.Clean(baseDir)+string(os.PathSeparator)) {

return "", fmt.Errorf("access to the path is restricted: %s", path)

}

Copilot · 2025-07-22T22:59:50Z

+		commitType = "feat"
+		if len(added) == 1 {
+			fileName := getFileName(added[0])
+			if fileName == "commit_message_tool.go" {


Hard-coded filename check creates brittle logic that will break if the file is renamed. This creates a maintenance burden and inconsistent behavior. Consider using more generic pattern matching or removing this special case.

Suggested change

if fileName == "commit_message_tool.go" {

if strings.Contains(fileName, "commit_message_tool") {

- Add proper error handling for json.MarshalIndent in FormatToolsPrompt - Fix all tool registry lookups to check existence before use - Add directory traversal protection in FileSystemTool - Replace hard-coded filename check with pattern matching

themusicman added 2 commits July 22, 2025 18:17

feat(tools): implement tool/function calling with LangChain for AI-po…

c595027

…wered system commands

Copilot AI review requested due to automatic review settings July 22, 2025 22:58

Copilot AI reviewed Jul 22, 2025

View reviewed changes

themusicman added 3 commits July 22, 2025 19:15

fix: update go.mod to use valid go version format

e692cb9

fix: update CI to support Go 1.22 and handle go.mod format

9f101ea

themusicman merged commit 3931025 into main Jul 23, 2025
5 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add AI-powered tool system with function calling capabilities#3

feat: Add AI-powered tool system with function calling capabilities#3
themusicman merged 5 commits intomainfrom
tool-usage

themusicman commented Jul 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Copilot AI Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-		params, _ := json.MarshalIndent(tool.Parameters(), "", "  ")
+		params, err := json.MarshalIndent(tool.Parameters(), "", "  ")
+		if err != nil {
+			toolDescriptions += "Tool: " + tool.Name() + "\n"
+			toolDescriptions += "Description: " + tool.Description() + "\n"
+			toolDescriptions += "Parameters: [Error formatting parameters: " + err.Error() + "]\n\n"
+			continue
+		}

-		tool, _ := s.registry.Get("shell")
+		tool, exists := s.registry.Get("shell")
+		if !exists {
+			return "", fmt.Errorf("shell tool is not registered in the tool registry")
+		}


		// Clean the path to prevent directory traversal
		path = filepath.Clean(path)

-	// Clean the path to prevent directory traversal
-	path = filepath.Clean(path)
+	// Define the base directory for file operations
+	baseDir := "/safe/base/directory"
+	// Clean the path to prevent directory traversal
+	path = filepath.Clean(path)
+	// Ensure the path is within the base directory
+	if !strings.HasPrefix(path, filepath.Clean(baseDir)+string(os.PathSeparator)) {
+		return "", fmt.Errorf("access to the path is restricted: %s", path)
+	}

	if fileName == "commit_message_tool.go" {
	if strings.Contains(fileName, "commit_message_tool") {

Conversation

themusicman commented Jul 22, 2025

Overview

✨ Key Features

🔧 Technical Changes

New Components

Enhanced Commands

Configuration Updates

📊 Stats

🚨 Breaking Changes

🧪 Usage Examples

Dependencies Added

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants