Repository navigation
Improve track selector with per-track mute and solo - #35
Merged
agourlay merged 5 commits intoNov 17, 2026
Merged
Conversation
Store solo state in a track bitmask like mute so several instruments can be soloed while keeping another track selected for tablature and toolbar actions. Co-authored-by: Cursor <cursoragent@cursor.com>
These build artifacts were not part of the track menu work. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Thanks again for the contribution! I will look into it in the coming days. |
- the track menu scrolls when it has more tracks than fit, instead of drawing unreachable rows past its bounds - the toolbar solo button reflects the current track, like mute - track names are clipped and never wrap - Ctrl/Cmd + wheel on the picker cycles tracks, like the stock pick_list - the picker reads solo/mute straight from the audio player - drop the unused menu tree, is_solo_active and a stale comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the custom TrackPicker widget, with its manual drawing and hit testing, by stock iced widgets: the picker is a button styled like the pick list, and the menu a scrollable column of track buttons with solo and mute toggles, floated over the tablature right under the toolbar. The app now owns whether the menu is open: it closes on track selection, a click outside, Escape, loading a song or fullscreen. The menu toggles are grey when off and highlighted when on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for this, multi-track solo plus per-track mute/solo in the menu is a nice improvement. I pushed two commits on top of your branch: f9fc67c: fixes on the custom widget
0e46541: rebuilt the menu from stock iced widgets
One behavior dropped compared to the stock pick list: Ctrl/Cmd + wheel on the picker no longer cycles tracks. The solo/mute semantics are unchanged from your version: mute wins, then solo excludes the rest. |
agourlay
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pick_listwith a custom dropdown: right-aligned wider menu, layout matching the stock control so the toolbar still fits.Test plan