Skip to content

Conversation

@steveoh
Copy link
Member

@steveoh steveoh commented Dec 12, 2025

remove no longer valid hub link
remove link to data page
add shelved pill with link to policy

https://deploy-preview-3160--gis-utah-gov.netlify.app/products/sgid/sgid-index/

image image

@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for gis-utah-gov ready!

Name Link
🔨 Latest commit 68b96f6
🔍 Latest deploy log https://app.netlify.com/projects/gis-utah-gov/deploys/69406deeec7eb800089b40da
😎 Deploy Preview https://deploy-preview-3160--gis-utah-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@steveoh steveoh requested review from eneemann and stdavis December 12, 2025 02:04
stdavis
stdavis previously approved these changes Dec 12, 2025
Copy link
Contributor

@eneemann eneemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good and I like the shelved "pill" addition. My only question is does it make sense to include a link to the AGOL item, too, instead of just the service URL? The AGOL item metadata might provide some additional insight on a specific dataset. The use case I'm thinking of is a specific tax year or political district year might have additional important context provided in the AGOL item description.

Edit: maybe this a moot comment. I see the description is on the feature service page, it's just more of a plain text style than the AGOL item page.

@eneemann
Copy link
Contributor

Edit: maybe this a moot comment. I see the description is on the feature service page, it's just more of a plain text style than the AGOL item page.

Looking closer, the feature service description and AGOL item descriptions aren't necessarily the same. In this case, we have auditor's "shelved" comment in the AGOL item description, but not the feature service description.
image

@stdavis
Copy link
Member

stdavis commented Dec 12, 2025

Thinking more about this...

I'm guessing that many of the users of our site have no idea what "shelved" means. I wonder if there should be a more apparent warning that the data may not be the most current version available. Maybe something like this:

"Shelved: Please note that this data may not be the most current version available"

@steveoh
Copy link
Member Author

steveoh commented Dec 15, 2025

does it make sense to include a link to the AGOL item, too, instead of just the service URL

This is a great idea. I'll look into it.

I wonder if there should be a more apparent warning that the data may not be the most current version available.

The pill is a link to the policy description. I could also add a tooltip. Since we use that terminology in AGOL and in policy, I think it is more acceptable for folks to learn what it mean. Maybe that is me living in a fantasy.

@steveoh steveoh enabled auto-merge (rebase) December 15, 2025 17:22
@stdavis stdavis disabled auto-merge December 15, 2025 18:23
stdavis
stdavis previously approved these changes Dec 15, 2025
Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you care about this minor display issue:

Image

I disabled auto-merge in case you wanted to fix this first.

stdavis
stdavis previously approved these changes Dec 15, 2025
eneemann
eneemann previously approved these changes Dec 15, 2025
Copy link
Contributor

@eneemann eneemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! I noticed the same minor visual issue that Scott noted, for the first item in the SGID Index list, but it looks like that's been resolved. Thanks for putting this in so quickly!

Co-authored-by: Scott Davis <[email protected]>
@steveoh steveoh dismissed stale reviews from eneemann and stdavis via 68b96f6 December 15, 2025 20:22
@steveoh steveoh disabled auto-merge December 15, 2025 20:22
@steveoh steveoh merged commit cf82f86 into main Dec 15, 2025
7 of 8 checks passed
@steveoh steveoh deleted the style/shelved branch December 15, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants