-
Notifications
You must be signed in to change notification settings - Fork 39
Improve shelved sgid index items #3160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gis-utah-gov ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good and I like the shelved "pill" addition. My only question is does it make sense to include a link to the AGOL item, too, instead of just the service URL? The AGOL item metadata might provide some additional insight on a specific dataset. The use case I'm thinking of is a specific tax year or political district year might have additional important context provided in the AGOL item description.
Edit: maybe this a moot comment. I see the description is on the feature service page, it's just more of a plain text style than the AGOL item page.
|
Thinking more about this... I'm guessing that many of the users of our site have no idea what "shelved" means. I wonder if there should be a more apparent warning that the data may not be the most current version available. Maybe something like this: "Shelved: Please note that this data may not be the most current version available" |
This is a great idea. I'll look into it.
The pill is a link to the policy description. I could also add a tooltip. Since we use that terminology in AGOL and in policy, I think it is more acceptable for folks to learn what it mean. Maybe that is me living in a fantasy. |
remove no longer valid hub link remove link to data page add shelved pill with link to policy refs #3131
e05b875 to
851d469
Compare
stdavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
851d469 to
512b058
Compare
eneemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! I noticed the same minor visual issue that Scott noted, for the first item in the SGID Index list, but it looks like that's been resolved. Thanks for putting this in so quickly!
Co-authored-by: Scott Davis <[email protected]>



remove no longer valid hub link
remove link to data page
add shelved pill with link to policy
https://deploy-preview-3160--gis-utah-gov.netlify.app/products/sgid/sgid-index/