Skip to content

Conversation

atlee025
Copy link
Contributor

@atlee025 atlee025 commented Mar 19, 2025

This PR adds a new divider component that accepts children elements (text) between a divider named DividerWithText

A link address was updated in the Github PR template to reflect the correct location.

Screenshot 2025-03-20 at 3 19 02 pm

View preview

View preview of Divider with Text Documentation

Checklist

Preflight

  • Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
  • Describe the changes clearly in the PR description
  • Read and check your code before tagging someone for review
  • Create a changeset file by running yarn changeset. Learn more about change management.

Testing

  • Manually test component in various modern browsers at various sizes (use Browserstack)
  • Manually test component in various devices (phone, tablet, desktop)
  • Manually test component using a keyboard
  • Manually test component using a screen reader
  • Manually tested in dark mode
  • Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
  • Add any necessary unit tests (HTML validation, snapshots etc)
  • Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

  • Create or update documentation on the website
  • Create or update stories for Storybook
  • Create or update stories for Playroom snippets

Creating new component

  • Add documentation for the component (docs/overview.mdx and docs/code.mdx at a minimum)
  • Preconstruct entrypoint has been created (run yarn in the root of the repo to do this)
  • Changeset file includes a minor
  • Export components for docs site and Playroom (docs/components/designSystemComponents.tsx)
  • Add component to Kitchen Sink (.storybook/stories/KitchenSink.tsx)
  • Add snippets to Playroom (docs/playroom/snippets.ts)
  • Add figmaGalleryNodeId to Docs (docs/components/[component-name]/overview.mdx)
  • Add pictogram to Docs (docs/components/pictograms/index.tsx)
    • currently same location as Divider

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 3906600

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ag.ds-next/react Minor
@ag.ds-next/docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atlee025 atlee025 changed the title divder-with-textadded divider-with-text component divder-with-text: create component Mar 19, 2025
Copy link
Contributor

github-actions bot commented Mar 19, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-04-03 00:52 UTC

@atlee025 atlee025 changed the title divder-with-text: create component divder-with-text: Initial release of component Mar 20, 2025
@atlee025 atlee025 marked this pull request as ready for review March 20, 2025 05:08
@atlee025 atlee025 requested a review from stowball March 20, 2025 05:08
Copy link

sonarqubecloud bot commented Apr 2, 2025

@atlee025 atlee025 merged commit 3fa4ead into develop Apr 3, 2025
8 checks passed
@atlee025 atlee025 deleted the divider-with-text-new-component branch April 3, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants