-
Notifications
You must be signed in to change notification settings - Fork 28
docs, conditional-field-container: update patterns and initial release of component #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7aef90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
atlee025
commented
Mar 26, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Mar 27, 2025
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
packages/react/src/conditional-reveal/ConditionalReveal.test.tsx
Outdated
Show resolved
Hide resolved
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
stowball
reviewed
Apr 1, 2025
example-site/components/FormExampleMultiStep/FormExampleMultiStep3.tsx
Outdated
Show resolved
Hide resolved
stowball
reviewed
Apr 1, 2025
packages/react/src/conditional-reveal/ConditionalReveal.stories.tsx
Outdated
Show resolved
Hide resolved
stowball
reviewed
Apr 1, 2025
packages/react/src/conditional-reveal/ConditionalReveal.test.tsx
Outdated
Show resolved
Hide resolved
stowball
reviewed
Apr 2, 2025
packages/react/src/conditional-reveal/ConditionalReveal.test.tsx
Outdated
Show resolved
Hide resolved
stowball
reviewed
Apr 2, 2025
Co-authored-by: Matt Stow <[email protected]>
stowball
reviewed
Apr 24, 2025
packages/react/src/conditional-field-container/docs/overview.mdx
Outdated
Show resolved
Hide resolved
stowball
reviewed
Apr 24, 2025
Co-authored-by: Matt Stow <[email protected]>
|
stowball
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the patterns page for Conditional Reveal to the new pattern. Added new component (ConditionalFieldContainer) to support the conditional reveal pattern and design.
Updated yourGov and example-site to match new conditional reveal pattern. Also modified yourGov form to refocus on a heading when form renders and duplicate require text.
View preview
View conditional-reveal patterns page
View conditional-field-container components page
Checklist
Preflight
accordion: Updated padding
ordocs: Updated header links
yarn changeset
. Learn more about change management.Testing
yarn test
to ensure tests are passing. If required, runyarn test -u
to update any generated snapshots.Documentation
Creating new component
docs/overview.mdx
anddocs/code.mdx
at a minimum)yarn
in the root of the repo to do this)docs/components/designSystemComponents.tsx
).storybook/stories/KitchenSink.tsx
)docs/playroom/snippets.ts
)figmaGalleryNodeId
to Docs (docs/components/pictograms/index.tsx
)docs/components/pictograms/index.tsx
)