Skip to content

main-nav: Always close mobile dialog on link click #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

main-nav: Always close mobile dialog on link click #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-squids-grab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ag.ds-next/react': patch
---

main-nav: Always close mobile dialog on link click to support updating `activePath` with Next.js‘ `usePathname`.
2 changes: 1 addition & 1 deletion packages/react/src/main-nav/MainNavDialogNavList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function MainNavDialogNavList({
<MainNavDialogNavListItem
active={active}
key={index}
onClick={active ? closeMobileMenu : undefined} // Let the click event bubble up and close the menu on press of interactive item
onClick={closeMobileMenu} // Let the click event bubble up and close the menu on press of interactive item
>
<Link aria-current={active ? 'page' : undefined} {...item}>
<span>{label}</span>
Expand Down
Loading