Skip to content

Conversation

ChrisLaneAU
Copy link

@ChrisLaneAU ChrisLaneAU commented Dec 12, 2024

Moves the Next.js pages-router approach to an app-router approach. The top level layout.tsx remains a React server component which implements a RootStyleRegistry, allowing for Emotion to work in the app-router.

@ChrisLaneAU ChrisLaneAU self-assigned this Dec 12, 2024
@ChrisLaneAU ChrisLaneAU changed the base branch from main to update-dependencies December 12, 2024 05:56
@ChrisLaneAU ChrisLaneAU requested a review from stowball December 13, 2024 00:50
@ChrisLaneAU ChrisLaneAU marked this pull request as ready for review December 13, 2024 00:50
"include": [
"**/*.ts",
"**/*.tsx",
".storybook/preview.tsx",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next rewrites the tsconfig file whenever the dev script is run. I don't think it's necessary but I can't figure out how to prevent this.

"**/*.tsx",
".storybook/preview.tsx",
"next-env.d.ts",
".next/types/**/*.ts"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

@stowball
Copy link

favicon.ico 404s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants