Skip to content

Conversation

@gschaffner
Copy link
Collaborator

Changes

Removes the BlockingPortal.__new__ hack. See #256 (comment):

This change would likely allow us to remove the __new__() hack from BlockingPortal.

Also documents :raises NoEventLoopError: for BlockingPortal().__init__.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • You've updated the documentation (in docs/), in case of behavior changes or new
    features
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@agronholm agronholm merged commit 74e77f8 into agronholm:master Dec 22, 2025
18 checks passed
@gschaffner gschaffner deleted the remove-BlockingPortal.__new__-hack branch December 22, 2025 22:42
agronholm pushed a commit that referenced this pull request Jan 6, 2026
* Remove BlockingPortal.__new__ hack
* Document NoEventLoopError in BlockingPortal constructor
* Remove unnecessary attribute

---------

Co-authored-by: Thomas Grainger <[email protected]>
(cherry picked from commit 74e77f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants