Skip to content

Added sendfile() support to socket streams - #1283

Draft
agronholm wants to merge 1 commit into
masterfrom
sendfile
Draft

Added sendfile() support to socket streams#1283
agronholm wants to merge 1 commit into
masterfrom
sendfile

Conversation

@agronholm

Copy link
Copy Markdown
Owner

NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!

Changes

Closes #1259.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • You've updated the documentation (in docs/), in case of behavior changes or new
    features
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/anyio/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@agronholm
agronholm requested a review from graingert August 16, 2026 13:29
@agronholm
agronholm marked this pull request as draft August 16, 2026 22:41
@agronholm
agronholm removed the request for review from graingert August 16, 2026 22:41
@agronholm

Copy link
Copy Markdown
Owner Author

This PR has...issues. I'll un-draft it when/if I've managed to solve them.

@agronholm

Copy link
Copy Markdown
Owner Author

One of the issues is that the fallback branch needs to call self.send() but that method grabs the send guard. The only solution is to make ResourceGuard re-entrant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose a sendfile API for socket streams

1 participant