Skip to content

Ensure socket aclose checkpoints after closing - #1291

Closed
hansu650 wants to merge 1 commit into
agronholm:masterfrom
hansu650:fix/unix-socket-aclose-checkpoint-1288
Closed

Ensure socket aclose checkpoints after closing#1291
hansu650 wants to merge 1 commit into
agronholm:masterfrom
hansu650:fix/unix-socket-aclose-checkpoint-1288

Conversation

@hansu650

Copy link
Copy Markdown
Contributor

NOTE Erasing or replacing the contents of this template will result in your pull
request being summarily closed without consideration!

Changes

Fixes #1288.

Add cancellation checkpoints after closing raw sockets in the asyncio and Trio
backends. This ensures that aclose() both releases the socket and delivers pending
cancellation. The regression test verifies both outcomes.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) which would fail without your patch
  • You've updated the documentation (in docs/), in case of behavior changes or new
    features (not applicable: this restores the expected cancellation checkpoint)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/anyio/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Collaborator

closing this as it's a dup of #1289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UNIXSocket.aclose and _TrioSocketMixin.aclose in cancelled scope does not raise a cancelled error (does not checkpoint)

2 participants