Test selector thread with closed socket #888
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
test-selector-thread
branch
2 times, most recently
from
f83e574 to
b05a28b
Compare
agronholm
reviewed
Mar 15, 2025
.github/workflows/test.yml
Outdated
Comment on lines
74
to
75
| - os: windows-latest | ||
| python-version: pypy-3.11 |
There was a problem hiding this comment.
I may veto this as it has caused too many issues in the past.
There was a problem hiding this comment.
Yeah I just wanted to see if I can trigger the bug more easily on PyPy.
There was a problem hiding this comment.
Anyway it seems the test suite won't run if there is no file change?
There was a problem hiding this comment.
You can omit that from the test workflow for the time being. Just put it back when this is ready for review.
davidbrochart
force-pushed
the
test-selector-thread
branch
from
9f8bf02 to
4c66919
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) added which would fail without your patchdocs/, in case of behavior changes or newfeatures)
docs/versionhistory.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.