Skip to content

Conversation

@vamega
Copy link

@vamega vamega commented Nov 15, 2023

The issue is described in #192.

Some notes:

  1. I don't know if this works on a Big-endian machine. One of the commits that was involved in breaking this specified was related to an issue on big-endian systems. I don't have access to a big-endian machine, and haven't invested time in setting up an environment where it can be tested.
  2. This doesn't handle the discrepancy between the value that reading the canonical field has. Right now it's always read as True or False.
  3. It also doesn't add any documentation of this parameter, which is probably important if it's to not regress.

The C implementation does not use the _encoders value that the Python
implementation uses.
Test that value 2 sets the canonical parameter to True
@coveralls
Copy link

coveralls commented Nov 15, 2023

Coverage Status

coverage: 93.069%. remained the same
when pulling 2bd36b8 on vamega:master
into a195c8e on agronholm:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants