Skip to content

Conversation

@YoonJeongLulu
Copy link
Collaborator

@YoonJeongLulu YoonJeongLulu commented Nov 7, 2024

What is this PR? ๐Ÿ”

๊ธฐ์กด ๋กœ๊ทธ์ธ ์ฝœ๋ฐฑ ํŽ˜์ด์ง€๊ฐ€ API route๋กœ ์ž‘์„ฑ๋˜์–ด์žˆ๋˜ ๋ถ€๋ถ„์„ ํŽ˜์ด์ง€ ๋ผ์šฐํŒ…์œผ๋กœ ์ „ํ™˜ํ•ฉ๋‹ˆ๋‹ค.

@YoonJeongLulu YoonJeongLulu marked this pull request as ready for review November 8, 2024 13:51
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹น์žฅ ์ค‘์š”ํ•œ ํ…Œ์ŠคํŠธ๊ฐ€ ์•„๋‹ˆ๋ผ skip ํ•ฉ๋‹ˆ๋‹ค.

return null;
}

export default function LoginCallbackPage() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next.js์—์„œ๋Š” useSearchParams์„ ์“ธ ๋•Œ suspense๋ฅผ ์จ์ฃผ์–ด์•ผ ํ•˜๊ตฐ์š”.
https://nextjs.org/docs/messages/missing-suspense-with-csr-bailout

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolveUser ์™€ ๊ฐ™์€ ๊ณผ์ •์ด ํ•„์š”ํ•˜๊ฒ ๊ตฐ์—ฌ
nookies๊นŒ์ง€ ์ €๋„ ํ•œ๋ฒˆ ๊ฒ€ํ† ํ•ด๋ณด๊ณ  ๋‹ค์‹œ ๋…ผ์˜ํ•ด๋ด์š”.
next-cookies๊ฐ€ ๋น„๋™๊ธฐ๋กœ ๊ฐ’์„ ๋ถˆ๋Ÿฌ์™€์•ผํ•œ๋‹ค๋ฉด AuthProvider๋ฅผ ํ•˜๋‚˜ ๊ฐ์‹ธ๋„ ์ข‹์ง€ ์•Š์„๊นŒ ์‹ถ์–ด์š”.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•ฑ ๋ผ์šฐํ„ฐ์—์„œ ์ด๋Ÿฐ Function์„ ์ œ๊ณตํ•˜๋„ค์š”.
https://nextjs.org/docs/app/api-reference/functions/cookies

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋น„๋™๊ธฐ๋กœ ์‚ฌ์šฉ๋˜๋Š” ๊ฒƒ๋„ ๋ฌธ์ œ๊ฐ€ ์•ˆ๋œ๋‹ค๋ฉด ์‚ฌ์šฉ ๋ฐฉ์‹์„ ์ถ”๊ฐ€๋กœ ๊ฒ€ํ† ํ•ด๋ณผ ํ•„์š”๋„ ์žˆ๊ฒ ๋„ค์š”!

} catch (error) {
console.error('Error during sign in:', error);
throw error;
if (axios.isAxiosError(error)) {
Copy link
Member

@createhb21 createhb21 Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—๋Ÿฌ ๊ณ„์ธต ๊ด€๋ฆฌ ์–ด๋–ค ์‹์œผ๋กœ ์žก์•„๋‚˜๊ฐˆ ์ˆ˜ ์žˆ์„์ง€
์œค์ •๋‹˜ ์„ค๊ณ„๊ฐ€ ๊ธฐ๋Œ€๋ผ์š” ...๐Ÿ˜‹

Copy link
Member

@createhb21 createhb21 Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ถ”ํ›„ ์—๋Ÿฌ ๋กœ๊น…์„ ํ•˜๋Š” ๊ธฐ๊ฐ„ ๊ณ ๋ คํ•˜๋ฉด
๋‹ค์Œ๊ณผ ๊ฐ™์€ ์‹์œผ๋กœ ๋ถ„๊ธฐ ์ฒ˜๋ฆฌ๋ฅผ ํ•ด๋ณด๋Š”๊ฒŒ ๋‚˜์„ ๊ฒƒ ๊ฐ™๊ธฐ๋„ ํ•œ๋ฐ
์–ด๋–ค๊ฐ€์š”?

const handleLogin = async () => {
    if (isLoadingRef.current) return

    const providerType = searchParams.get('type')
    const providerCode = searchParams.get('code')

    if (!providerType) {
      router.replace('/login?error=missing_provider_type')
      return
    }

    if (!providerCode) {
      router.replace('/login?error=missing_provider_code')
      return
    }

    if (!isValidSocialSignInType(providerType)) {
      router.replace(`/login?error=invalid_provider_type&type=${providerType}`)
      return
    }

    try {
      isLoadingRef.current = true
      const { result } = await requestLogin({
        providerType: providerType as SocialSignInType,
        providerCode,
      })

      const { accessToken, refreshToken } = result
      AuthService.setToken(accessToken, refreshToken)
      alert('๋กœ๊ทธ์ธ ์„ฑ๊ณต')
      router.replace('/')
    } catch (error) {
      console.error(error)
      alert(error instanceof Error ? error.message : '๋กœ๊ทธ์ธ ์ค‘ ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ–ˆ์Šต๋‹ˆ๋‹ค')
      router.back()
    } finally {
      isLoadingRef.current = false
    }
  }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!

} catch (error) {
// console.error(error);
alert(error);
router.back();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router.back()ํ•˜๋ฉด ์•ˆ๋˜์ง€ ์•Š๋‚˜์š”?
router.replace('/login?error=api_server_error')
์™€ ๊ฐ™์€ ๊ณณ์œผ๋กœ ์ฒ˜๋ฆฌํ•˜๋Š”๊ฒŒ ์–ด๋–จ๊นŒ์š”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €ํฌ ๋กœ๊ทธ์ธ ์‹คํŒจํ–ˆ์„ ๋•Œ ์—๋Ÿฌ ํŽ˜์ด์ง€ ๊ธฐํš์ด ์žˆ์—ˆ๋‚˜์š”?
๊ฒฐ๊ตญ ์œ„ ์ฝ”๋ฉ˜ํŠธ๋ž‘ ๋น„์Šทํ•œ ๊ฒƒ ๊ฐ™์€๋ฐ ๊ตฌ์ฒดํ™”๋  ๋•Œ ์ž‘์—…ํ•˜๋Š” ๊ฒŒ ์–ด๋–ค๊ฐ€ํ•ด์„œ์šค!

Copy link
Member

@createhb21 createhb21 Nov 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoonJeongLulu ๋„ค๋„ค!
์ง€๊ธˆ์€ ๋กœ๊ทธ์ธ ์—๋Ÿฌ ํŽ˜์ด์ง€๋Š” ๋”ฐ๋กœ ์—†์ด
๋กœ๊ทธ์ธ ํŽ˜์ด์ง€๋กœ ๋‹ค์‹œ ์ด๋™ํ•˜์ง€๋งŒ ์—๋Ÿฌ ์Šค๋‚ต๋ฐ”๋ฅผ ๋„์›Œ์ฃผ๊ธฐ๋งŒ ํ•˜๋Š”๊ฑธ ์ƒ๊ฐํ•˜๊ณ ์žˆ์–ด์š”

๊ตฌ์ฒดํ™”๋  ๋•Œ ๋‹ค์‹œ ์ž‘์—…ํ•˜๋ฉด ๋  ๊ฒƒ ๊ฐ™์•„์š” ๐Ÿ‘๐Ÿ‘

Copy link
Member

@createhb21 createhb21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

@YoonJeongLulu YoonJeongLulu merged commit 4cffce7 into develop Nov 10, 2024
2 checks passed
@YoonJeongLulu YoonJeongLulu deleted the fix/login branch November 10, 2024 12:11
YoonJeongLulu added a commit that referenced this pull request Nov 19, 2024
* chore: apply dynamically config (#236)

* apply dynamically config

* fix test case

* chore: add .pnp.cjs to .gitignore (#237)

* add .pnp.cjs to .gitignore

* delete /pnp.cjs

* feat: msw ํ™˜๊ฒฝ ๊ตฌ์ถ• (#235)

* feat: msw ํ™˜๊ฒฝ ๊ตฌ์ถ•

* feat: remove console

* feat: appEnvs

* feat: remove isMocking

* feat: remove v1 on handlers

* feat: remove .pnp.cjs

* feat: login callback api route (#239)

* feature middleware

* feature tokenService

* feature api routes

* fix post -> get

* update var name

* apply code review

* fix middleware

* remove unnessary codes

* apply code review

* apply code review

* feat: one-app env (#242)

* feature one-app env

* fix parsing error

* fix env

* feature site url

* feat: login pages (#241)

* feature login pages

* feature semantic naming

* remove console.log

* apply code review

* fix import error

* feat: add typescript compile check (#246)

* add typescript compile check

* add working directory

* fix: api server side routing -> client side  (#247)

* fix fix client side

* fix login structure

* make test skip

* wrap suspense to fix bugs

* fix middleware

* feat: nickname setup flow (#250)

* fix fix client side

* fix login structure

* make test skip

* wrap suspense to fix bugs

* feature nickname setup flow

* fix setToken when user has additionalInfo already

* refactor semantic namings

* refactor ํ›… ๋ถ„๋ฆฌ

* feature updateUser API Authorization

* remove unused components

* refactor zustand ์ตœ์ ํ™”

* fix ์˜คํƒˆ์ž

* fix renderIndicatorIcon naming

* apply code review

---------

Co-authored-by: Lulu <[email protected]>

* feat: one-app cd (#252)

* feature deploy web

* test deploy

* fix yml

* chore: add a comment (#253)

* add a comment

* fix route of dockerfile

* add AWS Credentials

* fix env

* fix deploy yml

* fix deploy yml

* Revert "fix deploy yml"

This reverts commit e856a97.

* Revert "fix deploy yml"

This reverts commit c501290.

* fix: typo in cicd script

* fix deploy.sh

* fix deploy yml

* fix typo

* fix typo

* fix typo

* remove unused

---------

Co-authored-by: createhb21 <[email protected]>
Co-authored-by: joohyun.ha <[email protected]>

* feat: โ™ป๏ธ MSW ๊ด€๋ จ ํ•จ์ˆ˜ ๋ฆฌํŒฉํ† ๋ง (#255)

---------

Co-authored-by: Hyobum Lee <[email protected]>
Co-authored-by: joohyun.ha <[email protected]>
@createhb21 createhb21 added the ๐Ÿช› Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง label Dec 21, 2024
createhb21 added a commit that referenced this pull request Jan 14, 2025
* chore: apply dynamically config (#236)

* apply dynamically config

* fix test case

* chore: add .pnp.cjs to .gitignore (#237)

* add .pnp.cjs to .gitignore

* delete /pnp.cjs

* feat: msw ํ™˜๊ฒฝ ๊ตฌ์ถ• (#235)

* feat: msw ํ™˜๊ฒฝ ๊ตฌ์ถ•

* feat: remove console

* feat: appEnvs

* feat: remove isMocking

* feat: remove v1 on handlers

* feat: remove .pnp.cjs

* feat: login callback api route (#239)

* feature middleware

* feature tokenService

* feature api routes

* fix post -> get

* update var name

* apply code review

* fix middleware

* remove unnessary codes

* apply code review

* apply code review

* feat: one-app env (#242)

* feature one-app env

* fix parsing error

* fix env

* feature site url

* feat: login pages (#241)

* feature login pages

* feature semantic naming

* remove console.log

* apply code review

* fix import error

* feat: add typescript compile check (#246)

* add typescript compile check

* add working directory

* fix: api server side routing -> client side  (#247)

* fix fix client side

* fix login structure

* make test skip

* wrap suspense to fix bugs

* fix middleware

* feat: nickname setup flow (#250)

* fix fix client side

* fix login structure

* make test skip

* wrap suspense to fix bugs

* feature nickname setup flow

* fix setToken when user has additionalInfo already

* refactor semantic namings

* refactor ํ›… ๋ถ„๋ฆฌ

* feature updateUser API Authorization

* remove unused components

* refactor zustand ์ตœ์ ํ™”

* fix ์˜คํƒˆ์ž

* fix renderIndicatorIcon naming

* apply code review

---------

Co-authored-by: Lulu <[email protected]>

* feat: one-app cd (#252)

* feature deploy web

* test deploy

* fix yml

* chore: add a comment (#253)

* add a comment

* fix route of dockerfile

* add AWS Credentials

* fix env

* fix deploy yml

* fix deploy yml

* Revert "fix deploy yml"

This reverts commit e856a97.

* Revert "fix deploy yml"

This reverts commit c501290.

* fix: typo in cicd script

* fix deploy.sh

* fix deploy yml

* fix typo

* fix typo

* fix typo

* remove unused

---------

Co-authored-by: createhb21 <[email protected]>
Co-authored-by: joohyun.ha <[email protected]>

* feat: โ™ป๏ธ MSW ๊ด€๋ จ ํ•จ์ˆ˜ ๋ฆฌํŒฉํ† ๋ง (#255)

* feat: text & theme tailwind setting (#259)

* feature text & theme setting

* revert font

* feat: โœจ ์œ ์‹ค๋ฌผ ๋ชฉ๋ก / ์œ ์‹ค๋ฌผ ์ƒ์„ธ API ์—ฐ๋™ (#262)

* SVG To direct rendering (#263)

* feat: ์œ ์‹ค๋ฌผ ํŽ˜์ด์ง€ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง๋“ค (์›น) - ๋ฆฌ์ŠคํŠธ, ์ƒ์„ธ, ํ•„ํ„ฐ  (#270)

* feature business logis

* resolve conflicts

* chore: ํ”ผ๊ทธ๋งˆ ๋””์ž์ธ ์‹œ์Šคํ…œ ํ…Œ์ผ์œˆ๋“œ ํ…Œ๋งˆ๋กœ ์ ์šฉ (#273)

* chore: ๋””์ž์ธ ์‹œ์Šคํ…œ์— ๋งž๊ฒŒ ์ปฌ๋Ÿฌ๊ฐ’ ์ˆ˜์ • ๋ฐ ์‹ ๊ทœ ์ถ”๊ฐ€ (#269)

* chore: ํฐํŠธ ์‚ฌ์ด์ฆˆ ํ…Œ์ผ์œˆ๋“œ ์‹œ์Šคํ…œํ™”(fontSize ํ•ญ๋ชฉ ํ™•์žฅ) (#269)

* chore: green ์ปฌ๋Ÿฌ์…‹ ์ถ”๊ฐ€ (#269)

* feat: ์œ ์‹ค๋ฌผ ํŽ˜์ด์ง€ (์›น) UI ์Šคํƒ€์ผ๋ง (#274)

* feature filter group setion styling

* reset filter styling

* article card styling, wip

* article detail page, wip

* article page detail styling, wip

* re-comment styling

* svgr typescript ์ง€์›

* fix build err

* chore: next.ahhachul.com ์‚ญ์ œ (#275)

* next.ahhachul.com ์‚ญ์ œ

* fix codeowners

* chore: ์ด์Šˆ ๋ฒˆํ˜ธ ์ž๋™์œผ๋กœ ๋ถ™๋„๋ก ์„ค์ • ์ถ”๊ฐ€ (#277) (#278)

* feat: ์œ ์‹ค๋ฌผ ๋ฆฌ์ŠคํŠธ, ์ƒ์„ธ, ๋Œ“๊ธ€ ๋ชฉ๋ก, ๋Œ“๊ธ€ ์ž…๋ ฅ ์ปดํฌ๋„ŒํŠธ UI ์ƒ์„ธ ์ž‘์—… (#276)

* feat: ๋Œ“๊ธ€ ์กฐํšŒ api ์—ฐ๋™

* ๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ ๋ฆฌ์ŠคํŠธ๊ฐ€ empty ์ผ๋•Œ ๋ณด์—ฌ์ฃผ๋Š” ํ™”๋ฉด

* loading uis

* add empty uis

* comment text filed ui

* lost112 article ์ผ์‹œ ์ƒ์„ธ ํ…Œ์ด๋ธ” ์ •๋ณด UI๊ฐ€ ์ถ”๊ฐ€๋œ๋‹ค

* article detail ๋‚ด๋ถ€ ์ด๋ฏธ์ง€

* img ๊ด€๋ จ typescipt ๋นŒ๋“œ ์—๋Ÿฌ ์ˆ˜์ •

* img ๊ด€๋ จ typescipt ๋นŒ๋“œ ์—๋Ÿฌ ์ˆ˜์ • 2

* img ๊ด€๋ จ typescipt ๋นŒ๋“œ ์—๋Ÿฌ ์ˆ˜์ • 3..

* refactor: isLexicalContent ์œ ํ‹ธ ํ•จ์ˆ˜๋ฅผ early return ๋ฐฉ์‹์œผ๋กœ ๋ณ€๊ฒฝ

* chore: ์ ˆ๋Œ€๊ฒฝ๋กœ import ํ•˜๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ, eslint ๊ด€๋ จ ๊ฒฝ๊ณ  ๋œจ๋Š” ํ˜„์ƒ ํ•ด๊ฒฐ (#282)

* feat: ๋Œ“๊ธ€ ์ƒ์„ฑ

* Absolute Path to Relative Path and Fix eslint rules errors

* chore: telemetry - false

* feat: ๋Œ“๊ธ€ ์ƒ์„ฑ (#283)

* resolve conficts

* feat: ์œ ์‹ค๋ฌผ ๊ธ€ ์ž‘์„ฑ ํŽ˜์ด์ง€ ๊ตฌ์„ฑ (#261)

* feat: add new type definitions for LostFound data

* feat: implemented basic UI components.

* feat: add shad/cn setting file

* chore: add library

* chore: etc work

* refactor: ์œ ์‹ค๋ฌผ ํŽ˜์ด์ง€ ๋ผ์šฐํ„ฐ ์žฌ๊ตฌ์„ฑ(์ˆ˜์ •, ์ƒ์„ฑ ๊ตฌ๋ถ„)  (#258)

* feat: ์ด๋ฏธ์ง€ ์—…๋กœ๋“œ/์‚ญ์ œ ๊ธฐ๋Šฅ ๊ตฌํ˜„ (#258)

* chore: ์ง€ํ•˜์ฒ  ํ˜ธ์„  ์•„์ด์ฝ˜ ์ถ”๊ฐ€ (#258)

* feat: ๋ฐ”ํ…€ ์‹œํŠธ ๊ตฌํ˜„ (#258)

* refactor: dto์— ์—†๋Š” ์ง€ํ•˜์ฒ  ํ˜ธ์„  ์ œ๊ฑฐ (#258)

* feat: lexical ์—๋””ํ„ฐ ์ถ”๊ฐ€ (#258)

* chore: svg ํƒ€์ž… ๋ช…์‹œ

* feat: ์œ ์‹ค๋ฌผ ๋“ฑ๋ก ๊ธฐ๋Šฅ ์ถ”๊ฐ€ (#258)

* chore: ์•„์ด์ฝ˜ ์†์„ฑ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ˆ˜์ • (#258)

* chore: ์ž„์‹œ๋กœ ์œ ์‹ค๋ฌผ ํŽ˜์ด์ง€ ๋“ฑ๋ก ๋งํฌ ์ถ”๊ฐ€ (#258)

* refactor: ์—๋””ํ„ฐ ๋นˆ ๊ฐ’ ํŒ๋‹จ ๋กœ์ง ์ถ”๊ฐ€ (#258)

* feat: ์œ ์‹ค๋ฌผ ๋ฐ์ดํ„ฐ ์กฐํšŒ ๊ธฐ๋ฐ˜์œผ๋กœ ํ™”๋ฉด์— ๋ฐ”์ธ๋”ฉ ์ฒ˜๋ฆฌ (#258)

* chore: ์œ ์‹ค๋ฌผ ๋ฐ์ดํ„ฐ์— ์˜ต์…”๋„ ์ฒด์ด๋‹ ์ ์šฉ (#258)

* chore: ์ด๋ฏธ์ง€ ์ œ๊ฑฐ ์•„์ด์ฝ˜ ์†์„ฑ ์ˆ˜์ • (#258)

* refactor: ์œ ์‹ค๋ฌผ ๋“ฑ๋ก/์ˆ˜์ • ๋กœ์ง ํ›…์œผ๋กœ ๋ถ„๋ฆฌ (#258)

* refactor: ์ฃผ์š” ๋กœ์ง ํ›…์œผ๋กœ ๋ถ„๋ฆฌ, ํƒ€์ž… ์ •๋ฆฌ (#258)

* chore: eslint ํŒŒ์ผ ์Šคํƒ€์ผ ๋ณ€๊ฒฝ (#258)

* refactor:  shadcn ์ปดํฌ๋„ŒํŠธ ์œ„์น˜ ์ด๋™ ๋ฐ ๊ธฐ๋ณธ ์„ค์น˜ ์œ„์น˜ ์ˆ˜์ • (#258)

* chore: ๋ถˆํ•„์š” console.log ์ œ๊ฑฐ (#258)

* chore: ๋””์ž์ธ ์‹œ์Šคํ…œ์— ๋งž๊ฒŒ ์ปฌ๋Ÿฌ๊ฐ’ ์ˆ˜์ • ๋ฐ ์‹ ๊ทœ ์ถ”๊ฐ€ (#269)

* chore: ํฐํŠธ ์‚ฌ์ด์ฆˆ ํ…Œ์ผ์œˆ๋“œ ์‹œ์Šคํ…œํ™”(fontSize ํ•ญ๋ชฉ ํ™•์žฅ) (#269)

* chore: green ์ปฌ๋Ÿฌ์…‹ ์ถ”๊ฐ€ (#269)

* refactor: LostFound ํƒ€์ž… ๋ช…์นญ ์ˆ˜์ • (#258)

* chore: ์ปดํฌ๋„ŒํŠธ ์Šคํƒ€์ผ ์ˆ˜์ •(ํ…Œ์ผ ์œˆ๋“œ ํ…Œ๋งˆ ์ ์šฉ) (#258)

* chore: ์„ค์น˜ ํŒŒ์ผ ๋™๊ธฐํ™” (#258)

* chore: ๋ถˆํ•„์š” ํƒ€์ž… ์ œ๊ฑฐ (#258)

* refactor:  ์œ ์‹ค๋ฌผ ์ˆ˜์ • ์‹œ์˜ ๋ฐ์ดํ„ฐ ๊ตฌ์„ฑ ๋กœ์ง ๋ณ€๊ฒฝ

* chore: yarn.lock ํŒŒ์ผ ์—…๋ฐ์ดํŠธ (#258)

* refactor: ์ค‘๋ณต ํƒ€์ž… ์ฝ”๋“œ ์ œ๊ฑฐ (#258)

* refactor: shadcn ์ปดํฌ๋„ŒํŠธ ์ˆ˜์ •(๋ช…์นญ ์ˆ˜์ • ๋ฐ ๋ถˆํ•„์š” ํ•˜์œ„ ์ปดํฌ๋„ŒํŠธ ์ œ๊ฑฐ)

* style: ๋ถˆํ•„์š” css ํ•ญ๋ชฉ ์ œ๊ฑฐ (#258)

* refactor: ์ค‘๋ณต๋˜๋Š” ์Šคํƒ€์ผ ์œ ํ‹ธํ•จ์ˆ˜ ์ œ๊ฑฐ (#258)

* refactor: ๊ธฐ์กด ํƒ€์ž… ์‚ฌ์šฉํ•˜๋„๋ก ์ ์šฉ (#258)

* chore: ๋ถˆํ•„์š” ํ”Œ๋Ÿฌ๊ทธ์ธ ์„ค์ •์—์„œ ์ œ๊ฑฐ (#258)

* style: ์กฐ๊ฑด๋ถ€ ์Šคํƒ€์ผ์— ๋Œ€ํ•ด cn ์œ ํ‹ธ ์ ์šฉ (#258)

* refactor: ์œ ์‹ค๋ฌผ ๋“ฑ๋ก/์ˆ˜์ • ์š”์ฒญ useMutation์œผ๋กœ ์ ์šฉ (#258)

* refactor: ๋ˆ„๋ฝ๋œ errorFallback ์ถ”๊ฐ€ (#258)

* refactor: adapter ๋‚ด์— lostId ์—†์„ ๊ฒฝ์šฐ ๊ธฐ๋ณธ ๊ฐ’์œผ๋กœ ๋ฆฌํ„ด๋˜๊ฒŒ ์„ค์ • (#258)

* refactor: ์œ ์‹ค๋ฌผ ์ˆ˜์ •/์ƒ์„ฑ ์ปดํฌ๋„ŒํŠธ ๋…๋ฆฝ์ ์œผ๋กœ ์ƒ์„ฑ ์ ์šฉ (#258)

* chore: ํƒ€์ž… ์˜ค๋ฅ˜ ์ œ๊ฑฐ

* chore: ์ปดํฌ๋„ŒํŠธ ์บํ”ผํ„ธ๋กœ ๋ฐ˜์˜

* chore: ์ปดํฌ๋„ŒํŠธ ์บํ”ผํƒˆ ๋‹ค์‹œ ์ ์šฉ๋˜๋„๋ก ์ฒ˜๋ฆฌ

* chore: ๋นŒ๋“œ ์—๋Ÿฌ ์ˆ˜์ •

* uupdate deploy-app.yml

---------

Co-authored-by: Lulu <[email protected]>
Co-authored-by: joohyun.ha <[email protected]>
Co-authored-by: ์ดํฌ์ œ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿช› Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants