chore: add a comment #253
Merged
chore: add a comment #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoonJeongLulu
force-pushed
the
chore/test
branch
from
1a28c99 to
6d1f2f6
Compare
YoonJeongLulu
force-pushed
the
chore/test
branch
from
116f883 to
4854bb8
Compare
YoonJeongLulu
added a commit
that referenced
this pull request
Nov 15, 2024
* feature deploy web * test deploy * fix yml * chore: add a comment (#253) * add a comment * fix route of dockerfile * add AWS Credentials * fix env * fix deploy yml * fix deploy yml * Revert "fix deploy yml" This reverts commit e856a97. * Revert "fix deploy yml" This reverts commit c501290. * fix: typo in cicd script * fix deploy.sh * fix deploy yml * fix typo * fix typo * fix typo * remove unused --------- Co-authored-by: createhb21 <[email protected]> Co-authored-by: joohyun.ha <[email protected]>
YoonJeongLulu
added a commit
that referenced
this pull request
Nov 19, 2024
* chore: apply dynamically config (#236) * apply dynamically config * fix test case * chore: add .pnp.cjs to .gitignore (#237) * add .pnp.cjs to .gitignore * delete /pnp.cjs * feat: msw ํ๊ฒฝ ๊ตฌ์ถ (#235) * feat: msw ํ๊ฒฝ ๊ตฌ์ถ * feat: remove console * feat: appEnvs * feat: remove isMocking * feat: remove v1 on handlers * feat: remove .pnp.cjs * feat: login callback api route (#239) * feature middleware * feature tokenService * feature api routes * fix post -> get * update var name * apply code review * fix middleware * remove unnessary codes * apply code review * apply code review * feat: one-app env (#242) * feature one-app env * fix parsing error * fix env * feature site url * feat: login pages (#241) * feature login pages * feature semantic naming * remove console.log * apply code review * fix import error * feat: add typescript compile check (#246) * add typescript compile check * add working directory * fix: api server side routing -> client side (#247) * fix fix client side * fix login structure * make test skip * wrap suspense to fix bugs * fix middleware * feat: nickname setup flow (#250) * fix fix client side * fix login structure * make test skip * wrap suspense to fix bugs * feature nickname setup flow * fix setToken when user has additionalInfo already * refactor semantic namings * refactor ํ ๋ถ๋ฆฌ * feature updateUser API Authorization * remove unused components * refactor zustand ์ต์ ํ * fix ์คํ์ * fix renderIndicatorIcon naming * apply code review --------- Co-authored-by: Lulu <[email protected]> * feat: one-app cd (#252) * feature deploy web * test deploy * fix yml * chore: add a comment (#253) * add a comment * fix route of dockerfile * add AWS Credentials * fix env * fix deploy yml * fix deploy yml * Revert "fix deploy yml" This reverts commit e856a97. * Revert "fix deploy yml" This reverts commit c501290. * fix: typo in cicd script * fix deploy.sh * fix deploy yml * fix typo * fix typo * fix typo * remove unused --------- Co-authored-by: createhb21 <[email protected]> Co-authored-by: joohyun.ha <[email protected]> * feat: โป๏ธ MSW ๊ด๋ จ ํจ์ ๋ฆฌํฉํ ๋ง (#255) --------- Co-authored-by: Hyobum Lee <[email protected]> Co-authored-by: joohyun.ha <[email protected]>
createhb21
added
the
โ๏ธ Chore
createhb21
added a commit
that referenced
this pull request
Jan 14, 2025
* chore: apply dynamically config (#236) * apply dynamically config * fix test case * chore: add .pnp.cjs to .gitignore (#237) * add .pnp.cjs to .gitignore * delete /pnp.cjs * feat: msw ํ๊ฒฝ ๊ตฌ์ถ (#235) * feat: msw ํ๊ฒฝ ๊ตฌ์ถ * feat: remove console * feat: appEnvs * feat: remove isMocking * feat: remove v1 on handlers * feat: remove .pnp.cjs * feat: login callback api route (#239) * feature middleware * feature tokenService * feature api routes * fix post -> get * update var name * apply code review * fix middleware * remove unnessary codes * apply code review * apply code review * feat: one-app env (#242) * feature one-app env * fix parsing error * fix env * feature site url * feat: login pages (#241) * feature login pages * feature semantic naming * remove console.log * apply code review * fix import error * feat: add typescript compile check (#246) * add typescript compile check * add working directory * fix: api server side routing -> client side (#247) * fix fix client side * fix login structure * make test skip * wrap suspense to fix bugs * fix middleware * feat: nickname setup flow (#250) * fix fix client side * fix login structure * make test skip * wrap suspense to fix bugs * feature nickname setup flow * fix setToken when user has additionalInfo already * refactor semantic namings * refactor ํ ๋ถ๋ฆฌ * feature updateUser API Authorization * remove unused components * refactor zustand ์ต์ ํ * fix ์คํ์ * fix renderIndicatorIcon naming * apply code review --------- Co-authored-by: Lulu <[email protected]> * feat: one-app cd (#252) * feature deploy web * test deploy * fix yml * chore: add a comment (#253) * add a comment * fix route of dockerfile * add AWS Credentials * fix env * fix deploy yml * fix deploy yml * Revert "fix deploy yml" This reverts commit e856a97. * Revert "fix deploy yml" This reverts commit c501290. * fix: typo in cicd script * fix deploy.sh * fix deploy yml * fix typo * fix typo * fix typo * remove unused --------- Co-authored-by: createhb21 <[email protected]> Co-authored-by: joohyun.ha <[email protected]> * feat: โป๏ธ MSW ๊ด๋ จ ํจ์ ๋ฆฌํฉํ ๋ง (#255) * feat: text & theme tailwind setting (#259) * feature text & theme setting * revert font * feat: โจ ์ ์ค๋ฌผ ๋ชฉ๋ก / ์ ์ค๋ฌผ ์์ธ API ์ฐ๋ (#262) * SVG To direct rendering (#263) * feat: ์ ์ค๋ฌผ ํ์ด์ง ๋น์ฆ๋์ค ๋ก์ง๋ค (์น) - ๋ฆฌ์คํธ, ์์ธ, ํํฐ (#270) * feature business logis * resolve conflicts * chore: ํผ๊ทธ๋ง ๋์์ธ ์์คํ ํ ์ผ์๋ ํ ๋ง๋ก ์ ์ฉ (#273) * chore: ๋์์ธ ์์คํ ์ ๋ง๊ฒ ์ปฌ๋ฌ๊ฐ ์์ ๋ฐ ์ ๊ท ์ถ๊ฐ (#269) * chore: ํฐํธ ์ฌ์ด์ฆ ํ ์ผ์๋ ์์คํ ํ(fontSize ํญ๋ชฉ ํ์ฅ) (#269) * chore: green ์ปฌ๋ฌ์ ์ถ๊ฐ (#269) * feat: ์ ์ค๋ฌผ ํ์ด์ง (์น) UI ์คํ์ผ๋ง (#274) * feature filter group setion styling * reset filter styling * article card styling, wip * article detail page, wip * article page detail styling, wip * re-comment styling * svgr typescript ์ง์ * fix build err * chore: next.ahhachul.com ์ญ์ (#275) * next.ahhachul.com ์ญ์ * fix codeowners * chore: ์ด์ ๋ฒํธ ์๋์ผ๋ก ๋ถ๋๋ก ์ค์ ์ถ๊ฐ (#277) (#278) * feat: ์ ์ค๋ฌผ ๋ฆฌ์คํธ, ์์ธ, ๋๊ธ ๋ชฉ๋ก, ๋๊ธ ์ ๋ ฅ ์ปดํฌ๋ํธ UI ์์ธ ์์ (#276) * feat: ๋๊ธ ์กฐํ api ์ฐ๋ * ๊ฒ์ ๊ฒฐ๊ณผ ๋ฆฌ์คํธ๊ฐ empty ์ผ๋ ๋ณด์ฌ์ฃผ๋ ํ๋ฉด * loading uis * add empty uis * comment text filed ui * lost112 article ์ผ์ ์์ธ ํ ์ด๋ธ ์ ๋ณด UI๊ฐ ์ถ๊ฐ๋๋ค * article detail ๋ด๋ถ ์ด๋ฏธ์ง * img ๊ด๋ จ typescipt ๋น๋ ์๋ฌ ์์ * img ๊ด๋ จ typescipt ๋น๋ ์๋ฌ ์์ 2 * img ๊ด๋ จ typescipt ๋น๋ ์๋ฌ ์์ 3.. * refactor: isLexicalContent ์ ํธ ํจ์๋ฅผ early return ๋ฐฉ์์ผ๋ก ๋ณ๊ฒฝ * chore: ์ ๋๊ฒฝ๋ก import ํ๋ ๋ฌธ์ ํด๊ฒฐ, eslint ๊ด๋ จ ๊ฒฝ๊ณ ๋จ๋ ํ์ ํด๊ฒฐ (#282) * feat: ๋๊ธ ์์ฑ * Absolute Path to Relative Path and Fix eslint rules errors * chore: telemetry - false * feat: ๋๊ธ ์์ฑ (#283) * resolve conficts * feat: ์ ์ค๋ฌผ ๊ธ ์์ฑ ํ์ด์ง ๊ตฌ์ฑ (#261) * feat: add new type definitions for LostFound data * feat: implemented basic UI components. * feat: add shad/cn setting file * chore: add library * chore: etc work * refactor: ์ ์ค๋ฌผ ํ์ด์ง ๋ผ์ฐํฐ ์ฌ๊ตฌ์ฑ(์์ , ์์ฑ ๊ตฌ๋ถ) (#258) * feat: ์ด๋ฏธ์ง ์ ๋ก๋/์ญ์ ๊ธฐ๋ฅ ๊ตฌํ (#258) * chore: ์งํ์ฒ ํธ์ ์์ด์ฝ ์ถ๊ฐ (#258) * feat: ๋ฐํ ์ํธ ๊ตฌํ (#258) * refactor: dto์ ์๋ ์งํ์ฒ ํธ์ ์ ๊ฑฐ (#258) * feat: lexical ์๋ํฐ ์ถ๊ฐ (#258) * chore: svg ํ์ ๋ช ์ * feat: ์ ์ค๋ฌผ ๋ฑ๋ก ๊ธฐ๋ฅ ์ถ๊ฐ (#258) * chore: ์์ด์ฝ ์์ฑ ์ฌ๋ฐ๋ฅด๊ฒ ์์ (#258) * chore: ์์๋ก ์ ์ค๋ฌผ ํ์ด์ง ๋ฑ๋ก ๋งํฌ ์ถ๊ฐ (#258) * refactor: ์๋ํฐ ๋น ๊ฐ ํ๋จ ๋ก์ง ์ถ๊ฐ (#258) * feat: ์ ์ค๋ฌผ ๋ฐ์ดํฐ ์กฐํ ๊ธฐ๋ฐ์ผ๋ก ํ๋ฉด์ ๋ฐ์ธ๋ฉ ์ฒ๋ฆฌ (#258) * chore: ์ ์ค๋ฌผ ๋ฐ์ดํฐ์ ์ต์ ๋ ์ฒด์ด๋ ์ ์ฉ (#258) * chore: ์ด๋ฏธ์ง ์ ๊ฑฐ ์์ด์ฝ ์์ฑ ์์ (#258) * refactor: ์ ์ค๋ฌผ ๋ฑ๋ก/์์ ๋ก์ง ํ ์ผ๋ก ๋ถ๋ฆฌ (#258) * refactor: ์ฃผ์ ๋ก์ง ํ ์ผ๋ก ๋ถ๋ฆฌ, ํ์ ์ ๋ฆฌ (#258) * chore: eslint ํ์ผ ์คํ์ผ ๋ณ๊ฒฝ (#258) * refactor: shadcn ์ปดํฌ๋ํธ ์์น ์ด๋ ๋ฐ ๊ธฐ๋ณธ ์ค์น ์์น ์์ (#258) * chore: ๋ถํ์ console.log ์ ๊ฑฐ (#258) * chore: ๋์์ธ ์์คํ ์ ๋ง๊ฒ ์ปฌ๋ฌ๊ฐ ์์ ๋ฐ ์ ๊ท ์ถ๊ฐ (#269) * chore: ํฐํธ ์ฌ์ด์ฆ ํ ์ผ์๋ ์์คํ ํ(fontSize ํญ๋ชฉ ํ์ฅ) (#269) * chore: green ์ปฌ๋ฌ์ ์ถ๊ฐ (#269) * refactor: LostFound ํ์ ๋ช ์นญ ์์ (#258) * chore: ์ปดํฌ๋ํธ ์คํ์ผ ์์ (ํ ์ผ ์๋ ํ ๋ง ์ ์ฉ) (#258) * chore: ์ค์น ํ์ผ ๋๊ธฐํ (#258) * chore: ๋ถํ์ ํ์ ์ ๊ฑฐ (#258) * refactor: ์ ์ค๋ฌผ ์์ ์์ ๋ฐ์ดํฐ ๊ตฌ์ฑ ๋ก์ง ๋ณ๊ฒฝ * chore: yarn.lock ํ์ผ ์ ๋ฐ์ดํธ (#258) * refactor: ์ค๋ณต ํ์ ์ฝ๋ ์ ๊ฑฐ (#258) * refactor: shadcn ์ปดํฌ๋ํธ ์์ (๋ช ์นญ ์์ ๋ฐ ๋ถํ์ ํ์ ์ปดํฌ๋ํธ ์ ๊ฑฐ) * style: ๋ถํ์ css ํญ๋ชฉ ์ ๊ฑฐ (#258) * refactor: ์ค๋ณต๋๋ ์คํ์ผ ์ ํธํจ์ ์ ๊ฑฐ (#258) * refactor: ๊ธฐ์กด ํ์ ์ฌ์ฉํ๋๋ก ์ ์ฉ (#258) * chore: ๋ถํ์ ํ๋ฌ๊ทธ์ธ ์ค์ ์์ ์ ๊ฑฐ (#258) * style: ์กฐ๊ฑด๋ถ ์คํ์ผ์ ๋ํด cn ์ ํธ ์ ์ฉ (#258) * refactor: ์ ์ค๋ฌผ ๋ฑ๋ก/์์ ์์ฒญ useMutation์ผ๋ก ์ ์ฉ (#258) * refactor: ๋๋ฝ๋ errorFallback ์ถ๊ฐ (#258) * refactor: adapter ๋ด์ lostId ์์ ๊ฒฝ์ฐ ๊ธฐ๋ณธ ๊ฐ์ผ๋ก ๋ฆฌํด๋๊ฒ ์ค์ (#258) * refactor: ์ ์ค๋ฌผ ์์ /์์ฑ ์ปดํฌ๋ํธ ๋ ๋ฆฝ์ ์ผ๋ก ์์ฑ ์ ์ฉ (#258) * chore: ํ์ ์ค๋ฅ ์ ๊ฑฐ * chore: ์ปดํฌ๋ํธ ์บํผํธ๋ก ๋ฐ์ * chore: ์ปดํฌ๋ํธ ์บํผํ ๋ค์ ์ ์ฉ๋๋๋ก ์ฒ๋ฆฌ * chore: ๋น๋ ์๋ฌ ์์ * uupdate deploy-app.yml --------- Co-authored-by: Lulu <[email protected]> Co-authored-by: joohyun.ha <[email protected]> Co-authored-by: ์ดํฌ์ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? ๐
Changes ๐
ScreenShot ๐ท
To Reviewers ๐ฌ