Correctly parse line comments on Windows/CRLF line endings#67
Open
sebastien-marichal wants to merge 1 commit intoaheber:mainfrom
Open
Correctly parse line comments on Windows/CRLF line endings#67sebastien-marichal wants to merge 1 commit intoaheber:mainfrom
sebastien-marichal wants to merge 1 commit intoaheber:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line_commentwas incorrectly including the\rcharacter on file using CRLF (Windows).This change updates the regex in the
line_commentrule to explicitly exclude\ralong with\n, changing the match pattern from/[^\n]*/to/[^\r\n]*/.I was not able to add a test in corpus. I tried to use the
:cstattribute with no avail so I could assert node length.Given the following file (with CRLF):
// test commentHere the previous parse value:
Now with the fix:
Command used for the output:
tree-sitter.exe parse --cst .\test.crlf.cls