Move code to src/ and project from setup.py to pyproject.toml#38
Open
Obi-Wan wants to merge 1 commit intoahendriksen:masterfrom
Open
Move code to src/ and project from setup.py to pyproject.toml#38Obi-Wan wants to merge 1 commit intoahendriksen:masterfrom
Obi-Wan wants to merge 1 commit intoahendriksen:masterfrom
Conversation
…ct.toml Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Collaborator
|
Thank you for this pull request! On first glance, it looks good. My contract at the CWI has ended, so I'm transferring Tomosipo to a new maintainer (Alexander Skorikov). He will decide whether to merge and whether anything else needs to be done. Sorry for not doing it myself, but I want to focus on finishing the last things for my PhD and finding a new job for now. |
Author
|
No worries @D1rk123, and thanks for letting me know. @askorikov, please let me know if you would like me to make more changes or fix any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The project description with a
setup.pyfile is deprecated since Python 3.12. Moreover, having the project source code in a non-standard directory makes it unindexed by IDEs like vscode. Moving topyproject.tomlwould allow building with recent Python versions, while moving the code under thesrcdirectory would add autocompletion to vscode.What was done
setup.pywith apyproject.tomlfiletomosipotosrc/tomosipo