Feature/mifan #252
Open
Feature/mifan #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roken iOS Devices"
1. adjust some words in docs/ios-token-without-reset.md 2. adjust cropping of hexyl-output screenshot 3. add reference of ios-token-without-reset.md to management.md
currently, only finished requirements of the following capabilities: Power, Buzzer, SwitchableLED
1. added partial support for 2 electric fans from xiaomi 米家直流变频落地扇 1x (dmaker.fan.p5) Working: "power", "fanSpeed", "mode", "led", "roll", "roll_angle", "child_lock" Need to implement: - "poweroff_time": capability and adoption - "buzzer": need to figure out the internal property name - "rotate by 5 degrees": need to figure out the internal property name - verification for validity of roll_angle input (zhimi.fan.sa1) Working: "power", "buzzer", "fanSpeed", "ledBrightness" "roll", "roll_angle", "child_lock" Need to implement: - "poweroff_time": capability and adoption - "rotate by 5 degrees": need to figure out the internal property name - verification for validity of roll_angle input 2. added the following capabilities: - SwitchableRoll - SwitchableChildLock - RollAngleRanges - RollAngle - AdjustableRollAngle
with minor change in changePower(power) in mi-fan.js remove input conversion as that is done in setPower. the public interface is power(power) which changes power state through setPower
minor uppdate in mifan document minor styling change in changeBuzzer() in Buzzer capability definition rename mi-fan.js to dmaker-fan.js reorganize js files related to fans into a folder 'fan'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented everything except the following features for the 4 types of Fans by Xiaomi: