Update Rust crate bzip2 to 0.6 - #221
Conversation
|
PR author is in the excluded authors list. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9517ae908
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| checksum = "09edd9e8b54e49e587e4f6295a7d29c3ea94d469cb40ab8ca70b288248a81db2" | ||
|
|
||
| [[package]] | ||
| name = "libbz2-rs-sys" |
There was a problem hiding this comment.
Restore cargo-deny license compatibility
Upgrading to bzip2 = "0.6" pulls in libbz2-rs-sys (visible in Cargo.lock), but the repository license policy currently allows only MIT/Apache/BSD/ISC/Unicode/Zlib (deny.toml:5-15), and CI always runs cargo-deny check --all-features (.github/workflows/ci.yml:359-374). Because libbz2-rs-sys uses the bzip2-1.0.6 license, this change will make the dependency-lint job fail on every PR/build until the allowlist or dependency choice is adjusted.
Useful? React with 👍 / 👎.
e9517ae to
43ad49e
Compare
43ad49e to
fbdeafe
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
fbdeafe to
3292d0b
Compare
3292d0b to
0e8dc82
Compare
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found in unchanged code that cannot receive inline comments. Files Reviewed (2 files)
Reviewed by gpt-5.5-2026-04-23 · 482,081 tokens |
This PR contains the following updates:
0.5→0.6Release Notes
trifectatechfoundation/bzip2-rs (bzip2)
v0.6.1Compare Source
v0.6.0Compare Source
Highlights
This release switches to libbz2-rs-sys as the default bzip2 backend. It is written in rust, making it much easier to cross-compile. The new implementation is also more performant.
The rust implementation does not export C symbols by default. An explicit dependency on
libbz2-rs-sysand setting theexport-symbolsfeature flag will fix that if needed.The
bzip2-sysfeature flag can be used to continue to use the C backend (either the system library of a C version built from source).This is a breaking release, given that we want this update to be opt-in. We've used the occasion to perform an MSRV bump to
1.82.0. Thelibbz2-rs-syscrate has thebzip2-1.0.6license. Arguably, that is the license thatbzip2-sysshould have had too, given that it is just a wrapper of the original bzip2 (andlibbz2-rs-sysis a derivative work). You may need to allow this license when usingcargo-deny.What's Changed
Full Changelog: trifectatechfoundation/bzip2-rs@v0.5.2...v0.6.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.