[Experimental] SIMD nonsense - #2
Open
ahrav wants to merge 2 commits into
Open
Conversation
Add support for Go 1.26's experimental `simd/archsimd` package to accelerate root-state skipping when the pattern set has 16 or fewer distinct starting bytes. This feature is only available on
Owner
Author
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmarks
linux/amd64, go1.26rc2, AMD Ryzen 9 9950X
Commands:
go test -bench=BenchmarkMatchIbsen -benchmem -run=^$ -count=6 ./...
GOEXPERIMENT=simd go test -bench=BenchmarkMatchIbsen -benchmem -run=^$ -count=6 ./...
Time (sec/op)
Memory
B/op and allocs/op unchanged for 100, 1000, 10000; 100000 B/op improves -34.59% (p=0.002 n=6).