Fixes ligature transposition bug #1617 - #1621
Merged
Merged
Conversation
reorder_stext_line(...) used an unstable sort which resulted in ligature elements and following characters getting transposed. Using a stable sort instead fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ahrm,
I found the culprit for #1617. It's basically identical to 627c3ef. The
reorder_stext_lineutility function used an unstable sort which I'm guessing is why you couldn't reproduce the issue.As an aside, it might be worth adding a comment to the reordering function. It looks a bit odd (redundant) at first to do the reordering in both cases. I think it was added in 5016bc5 as part of handling malformed text.