Fix windows version - #1670
Open
dtristany wants to merge 16 commits into
Open
Conversation
Update actions to latest to support Node 24. Node 20 gets fully removed from GitHub runners on September 16, 2026 so older file will hard-fail once that lands.
qt 6.11 introduces subfolders for each architecture, which is not supported by older versions of aqtinstall
The Windows MSVC build currently fails with error C7555 because `main_widget.cpp` uses designated initializers but `pdf_viewer_build_config.pro` restricts the build to C++17. Unlike other compilers, MSVC strictly enforces standard flags and hard-stops when encountering C++20 syntax in C++17 mode. This commit appends `/std:c++20` to `QMAKE_CXXFLAGS` within the `win32` block of the .pro file.
by not building mupdf debug needlessly, 10min per build are saved,
Since that is what Qt 6 expects
NON-PORTABLE was previously hardcoded for all releases
Latest security fixes
remove automatic releases
remove automatic releases
No longer required as project now uses c++20 for all builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamline build process with yaml.
Pin to latest compatible mupdf, openssl and zlib for latest security fixes.
Fix issue that would not allow building windows portable version.
Fix issue #1669 without changing c++ version for other platforms.