Add simple addFile function #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might seem a bit strange, but let's say you store all your JS files in a
directory. Now, you want to host your service-worker.js in the root (for
scope reasons). This will allow you to do addFile('/service-worker.js',
'./js/service-worker.js');
This basically is a little bit of url-rewriting for an individual file.
Patch is untested as on debian9 the string_view is in std::experimental.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might seem a bit strange, but let's say you store all your JS files in a
directory. Now, you want to host your service-worker.js in the root (for
scope reasons). This will allow you to do addFile('/service-worker.js',
'./js/service-worker.js');
This basically is a little bit of url-rewriting for an individual file.
Patch is untested as on debian9 the string_view is in std::experimental.
It would be great if you (ahu) could review is this is actually the right way to do it.