Skip to content

feat: introduce profiler UI #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tianhaox merged 28 commits into from
Dec 3, 2025
Merged

feat: introduce profiler UI #117

tianhaox merged 28 commits into from
Dec 3, 2025

Conversation

@Harrilee
Copy link
Contributor

@Harrilee Harrilee commented Nov 20, 2025 •
edited
Loading

No description provided.

@Harrilee Harrilee requested a review from tianhaox as a code owner November 20, 2025 19:43
@github-actions github-actions bot added the feat label Nov 20, 2025
@Harrilee Harrilee requested a review from a team as a code owner December 1, 2025 22:35
Harrilee and others added 21 commits December 1, 2025 14:50
@Harrilee
feat(profiler_ui): initial commit
0dd3e65 
- basic form
- interactivet plot
- selection logic with table
@Harrilee
feat: refactor with Chartjs and datatables
7b57444
@Harrilee
docs: update description
209a150
@Harrilee
feat: allow user to confirm the selected datapoint
16a4d74
@Harrilee
feat: add standalone app to use the ui
642835a
@Harrilee
feat: download config button
3e18ce9
@Harrilee
fix: datatables drop down style fix
bb76b39
@Harrilee
fix: MoE support
99ea7ec
@Harrilee
feat: add capabilities for required/optional fields
b893e9c
@Harrilee
fix: profiling result hierachy
f638f7b
@Harrilee
chores: styles and prompts
e970c20
@Harrilee
feat: input validation
121a7a6
@Harrilee
chore: hide 'select' button
eb9beb3
@Harrilee
feat: render config yaml with syntax highlight
323cf39
@tedzhouhk @Harrilee
add dep (#121)
7c9eaa5 
Signed-off-by: hongkuanz <hongkuanz@nvidia.com>
@Harrilee
fix: highlight js rerendering
cc0bdc9
@Harrilee
feat: add huristic point selection logic
36ee925
@Harrilee
fix: add copyyright info
f354b32
@Harrilee
feat: add JS linter
d0f3c02
@Harrilee
feat: add js linter
18f6aa5
@Harrilee
feat: add lint check to workflow
5d3cfb0
jasonqinzhou
jasonqinzhou reviewed Dec 2, 2025
View reviewed changes
@jasonqinzhou
Copy link
Contributor

jasonqinzhou commented Dec 2, 2025 •
edited
Loading

Can you create a PR that only includes the functions Dynamo Planner are going to use and keep the tab Profiling in another draft PR?
The issue is I think the Profiling tab is not ready yet. Currently the tab is designed for Dynamo Planner profiler's config selection but AIC doesn't have the disagg_worker_max mode to support this selection logic.
Once we have disagg_worker_max mode we can add the tab that Dynamo Planner has to AIC.

FYI: I have updated this PR with hiding profiling tab by default.

@Harrilee
Copy link
Contributor Author

Harrilee commented Dec 2, 2025 •
edited
Loading

FYI: I have updated this PR with hiding profiling tab by default.

Have you considered using the existing --experimental flag? @jasonqinzhou

@jasonqinzhou
Copy link
Contributor

jasonqinzhou commented Dec 2, 2025

FYI: I have updated this PR with hiding profiling tab by default.

Have you considered using the existing --experimental flag? @jasonqinzhou

That's for enabling SOL Mode box.

tianhaox
tianhaox reviewed Dec 2, 2025
View reviewed changes
tianhaox
tianhaox reviewed Dec 2, 2025
View reviewed changes
tianhaox
tianhaox reviewed Dec 2, 2025
View reviewed changes
@simone-chen
Copy link
Contributor

simone-chen commented Dec 2, 2025

Spot a very small UX bug when changing inference framework version. The error pop-up window is a bit confusing.

Screen.Recording.2025-12-02.at.12.43.00.PM.mov

@Harrilee
Copy link
Contributor Author

Harrilee commented Dec 2, 2025

Spot a very small UX bug when changing inference framework version. The error pop-up window is a bit confusing.

Screen.Recording.2025-12-02.at.12.43.00.PM.mov

Thx. Fixed now.

Gradio's Dropdown throws an error when dynamically-updated choices don't include the frontend's stale value. Fixed by patching preprocess to return None instead of raising the exception.

@tianhaox tianhaox enabled auto-merge (squash) December 3, 2025 05:32
@tianhaox tianhaox disabled auto-merge December 3, 2025 05:32
@tianhaox tianhaox merged commit bdc1426 into main Dec 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tedzhouhk tedzhouhk tedzhouhk left review comments

@tianhaox tianhaox tianhaox approved these changes

@jasonqinzhou jasonqinzhou jasonqinzhou approved these changes

@Arsene12358 Arsene12358 Arsene12358 approved these changes

@saturley-hall saturley-hall Awaiting requested review from saturley-hall

@YijiaZhao YijiaZhao Awaiting requested review from YijiaZhao YijiaZhao is a code owner

@ilyasher ilyasher Awaiting requested review from ilyasher ilyasher is a code owner

@xutizhou xutizhou Awaiting requested review from xutizhou xutizhou is a code owner

@AichenF AichenF Awaiting requested review from AichenF AichenF is a code owner

Assignees

No one assigned

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Harrilee @jasonqinzhou @simone-chen @tedzhouhk @tianhaox @Arsene12358