perf: cache repeated queries to perf database and match_workers #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish-shanbhag
requested review from
AichenF,
Arsene12358,
YijiaZhao,
ilyasher,
jasonqinzhou,
saturley-hall,
tianhaox and
xutizhou
as code owners
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
anish-shanbhag
force-pushed
the
ashanbhag/cache-perf-db
branch
from
e342e0e to
1b17805
Compare
tianhaox
reviewed
Nov 25, 2025
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
tianhaox
approved these changes
Nov 26, 2025
Arsene12358
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This change updates the perf database and
match_workersto cache repeated queries, which should be fine since these operations don't appear to have any side effects.Details:
In my local testing, this speeds up
aiconfigurator cli default --model QWEN3_32B --total_gpus 32 --system h200_sxmfrom206s-->9sWhere should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)