Skip to content

fix: cli for gb200 when tp > 4 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tianhaox wants to merge 1 commit into from
Closed

fix: cli for gb200 when tp > 4 #135

tianhaox wants to merge 1 commit into from

Conversation

@tianhaox
Copy link
Contributor

@tianhaox tianhaox commented Nov 26, 2025

Several fixes

  1. cli should use tokens/s/gpu_cluster to draw frontier
  2. fix gb200 custom ar when tp size > 4, use nccl all_reduce.
  3. fix minor problems after linting.

@tianhaox
fix: cli should use tokens/s/gpu_cluster to draw frontier; fix gb200 …
8d851de 
…custom ar when tp size > 4; fix minor problems after linting.

Signed-off-by: Tianhao Xu <tianhaox@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the fix label Nov 26, 2025
@tianhaox tianhaox marked this pull request as draft November 26, 2025 13:26
@tianhaox tianhaox marked this pull request as ready for review November 26, 2025 13:26
@tianhaox tianhaox closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YijiaZhao YijiaZhao YijiaZhao approved these changes

@Ethan-ES Ethan-ES Ethan-ES approved these changes

@liyuanzhe1991 liyuanzhe1991 liyuanzhe1991 approved these changes

@Arsene12358 Arsene12358 Awaiting requested review from Arsene12358 Arsene12358 is a code owner

@ilyasher ilyasher Awaiting requested review from ilyasher ilyasher is a code owner

@xutizhou xutizhou Awaiting requested review from xutizhou xutizhou is a code owner

@AichenF AichenF Awaiting requested review from AichenF AichenF is a code owner

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tianhaox @YijiaZhao @Ethan-ES @liyuanzhe1991