feat: Add k8s_hf_home option #303
Open
+114
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyasher
requested review from
a team,
Arsene12358,
Ethan-ES,
Harrilee,
YijiaZhao,
davilu-nvidia,
jasonqinzhou and
tianhaox
as code owners
Signed-off-by: Ilya Sherstyuk <isherstyuk@nvidia.com>
ilyasher
force-pushed
the
dev-isherstyuk-add-k8s-hf-home
branch
from
9c399ec to
7ed0965
Compare
simone-chen
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
If
k8s_model_cacheis specified while generating the a dynamo k8s deployment config, set theHF_HOMEenvironment variable to the path where the model cache is mounted, so that HF actually makes use of the mounted directory for caching HF downloads.Also add a new option,
--generator-set K8sConfig.k8s_hf_home=/path/to/hf/home, to override the HF_HOME variable, which could be useful if the HF_HOME dir isn't at the root of the mounted path.