ci: automate unit testing for pull requests #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-david-oy
force-pushed
the
dyas-unit-tests
branch
from
569d262 to
e19ac56
Compare
the-david-oy
changed the title
Update file dir Active virtual env Fix dir name Add ls for debugging Change dir navigation Update pythonpath Use make test Fix some of unit test failures Add yield to mock Fix two more tests Fix two more tests Fix last test
the-david-oy
force-pushed
the
dyas-unit-tests
branch
from
408a338 to
f7d0ee1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements automated unit testing for pull requests and fixes multiple failing unit tests to enable the CI workflow.
Key changes include:
- Added GitHub Actions workflow for automated unit testing on PRs
- Fixed test data structure mismatches (attribute name corrections)
- Updated test mocking strategies to properly handle async operations
- Added missing imports and adjusted test fixtures
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/run-unit-tests.yml |
New GitHub Actions workflow to run unit tests on pull requests |
tests/test_background_task.py |
Added event loop yields after task stop to ensure proper test timing |
tests/services/test_inference_result_parser.py |
Fixed attribute names from text/content to texts/contents |
tests/services/records_manager/test_streaming_post_processor.py |
Updated test setup with proper factory registration and async task handling |
tests/services/records_manager/test_processing_stats_streamer.py |
Added async mocking for pub_client to prevent test failures |
tests/logging/test_logging_mixins.py |
Fixed logger level setting for proper lazy evaluation testing |
tests/data_exporters/test_json_exporter.py |
Updated test to match expected JSON structure with records wrapper |
tests/data_exporters/test_exporter_manager.py |
Enhanced mocking to handle multiple exporters with proper async assertions |
tests/config/test_base_config.py |
Changed import from Pydantic BaseModel to AIPerfBaseModel |
aiperf/common/config/user_config.py |
Fixed syntax error in field annotation |
tests/services/records_manager/test_streaming_post_processor.py
Outdated
Show resolved
Hide resolved
tests/services/records_manager/test_streaming_post_processor.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run automated unit testing on pull requests. This PR fixes currently failing unit tests.