fix: github pre-commit job #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcasagrande
force-pushed
the
ajc/fix-mkinit-script
branch
from
7a8f7f2 to
21aee52
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the GitHub pre-commit job by addressing dependency issues and updating action versions. The changes ensure that the mkinit package is properly available during pre-commit execution and modernize the workflow configuration.
- Updates GitHub Actions workflow to use newer action versions and Ubuntu latest
- Adds virtual environment activation to the init file generation script
- Refactors Makefile to separate virtual environment setup from mkinit installation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/pre-commit.yml | Updates action versions, adds Python setup, and installs mkinit dependency |
| tools/generate_init_files.sh | Adds virtual environment activation to ensure mkinit is available |
| Makefile | Separates setup tasks and adds mkinit installation target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
the-david-oy
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the pre-commit hook added in #276 by ensuring the mkinit package is installed, and the venv is used for running mkinit