Skip to content

Conversation

@ajcasagrande
Copy link
Contributor

@ajcasagrande ajcasagrande commented Nov 3, 2025

Summary by CodeRabbit

  • Chores
    • Established automated Docker-based integration testing infrastructure that runs on all pull requests and commits to the main branch. Tests execute within containerized environments using parallelized execution to improve code validation consistency and reduce deployment risks.

@github-actions github-actions bot added the test label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@ajc/docker-tests

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@ajc/docker-tests

@ajcasagrande ajcasagrande marked this pull request as draft November 3, 2025 21:22
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/aiperf/dataset/generator/video.py 33.33% 16 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Walkthrough

A new GitHub Actions workflow is added that automates Docker-focused integration testing. The workflow triggers on pull requests and pushes to main, builds a Docker image using Buildx, runs a container with the repository mounted, installs dependencies, and executes integration tests with specific marker filters and parallelization.

Changes

Cohort / File(s) Summary
Docker Integration Test Workflow
.github/workflows/docker-integration-tests.yml
New workflow file that defines a CI pipeline for Docker-based integration testing, including Docker image build and push steps, container execution with mounted volumes, Python virtual environment activation, dependency installation, and pytest execution with marker filtering and parallel test execution.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Docker Buildx configuration (context, target, caching) correctness and alignment with project structure
  • Test marker filtering logic (integration and not performance and not stress) to ensure intended test scope
  • Virtual environment and dependency installation within container
  • Pytest parallelization settings and output verbosity configuration

Poem

🐰 A workflow springs forth, Docker-bound and bright,
Building images, testing through the night,
Containers spin with Python's embrace,
Integration tests dash at quickened pace! 🏃‍♂️✨

Pre-merge checks

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a GitHub Actions workflow file for Docker-based integration tests.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd9c52e and 16b4051.

📒 Files selected for processing (1)
  • .github/workflows/docker-integration-tests.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: integration-tests (macos-latest, 3.11)
  • GitHub Check: integration-tests (ubuntu-latest, 3.11)
  • GitHub Check: integration-tests (macos-latest, 3.12)
  • GitHub Check: integration-tests (ubuntu-latest, 3.12)
  • GitHub Check: integration-tests (macos-latest, 3.10)
  • GitHub Check: integration-tests (ubuntu-latest, 3.10)
  • GitHub Check: build (macos-latest, 3.10)
  • GitHub Check: docker-integration-tests
🔇 Additional comments (1)
.github/workflows/docker-integration-tests.yml (1)

1-39: All verifications passed—workflow configuration is correct.

The Docker integration tests workflow is properly configured:

  • ✓ Venv at /opt/aiperf/venv/bin/activate is created in the env-builder target and correctly copied to the final image
  • uv is installed from the official ghcr.io/astral-sh/uv:latest image and available in the container
  • tests/integration/ directory exists with proper pytest markers (@pytest.mark.integration, @pytest.mark.stress) that match the workflow's test selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants