Skip to content

Conversation

@ganeshku1
Copy link
Member

Summary

Fixes 4 failing doctest examples by making each test block self-contained and independent.

Changes

  • trace_replay.md: Combined file creation and AIPerf execution into single test block
  • trace_replay.md: Chained multi-command bash script with && operators for mooncake trace download
  • fixed-schedule.md: Added file creation to time window execution test

Problem

The doctest CI was failing on 4 tests because they depended on files created in previous test blocks. Since each test block runs independently in the CI environment, these dependencies caused failures.

Solution

Each test block now creates all necessary files before executing AIPerf commands, making tests self-contained and reproducible in isolation.

Test Results

  • Before: 29 tests (4 failing: tests 3, 4, 18, 19)
  • After: 28 tests (all passing, 100% success rate)
  • Execution time: 20.5 minutes
  • Exit code: 0 ✅

Files Modified

docs/benchmark_modes/trace_replay.md | 13 +++----------
docs/tutorials/fixed-schedule.md     | 16 +++++++++++++++-
2 files changed, 18 insertions(+), 11 deletions(-)

Verification

Full doctest suite run confirms all 28 tests now pass successfully.

- Combine file creation and aiperf execution in trace_replay.md test
- Chain multi-command bash scripts with && operators in mooncake trace example
- Add file creation to time window execution test in fixed-schedule.md

This ensures each doctest block can run independently without
dependencies on previous test blocks, fixing 4 failing tests.

Fixes: Tests 3, 4, 18, 19 in doctest CI
Test count: 29 -> 28 (combined dependent tests)
@github-actions
Copy link

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@911c9844bf450a1a6462803870c83a79b24f9b3e

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@911c9844bf450a1a6462803870c83a79b24f9b3e

Last updated for commit: 911c984Browse code

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ajcasagrande
Copy link
Contributor

@ganeshku1 can you resolve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants