-
Notifications
You must be signed in to change notification settings - Fork 638
feat: python package build with abi (cross py3.10+) #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi michaelfeil! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Signed-off-by: michaelfeil <[email protected]>
72012f9
to
41285dc
Compare
Signed-off-by: michaelfeil <[email protected]>
WalkthroughBroadened the ai_dynamo_runtime wheel selection from cp312-specific to any matching wheel across multiple Dockerfiles. Enabled the pyo3 abi3-py310 feature in the Python bindings Cargo.toml to build against a stable Python ABI. No public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Okay, this is a good as is. @kthui (or anyone else?) can you kick of the |
/ok to test 3e93858 |
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit