-
Notifications
You must be signed in to change notification settings - Fork 638
docs: add a doc for framework lib versions #3572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/ok to test 51d3cb6 |
51d3cb6
to
a76a621
Compare
WalkthroughAdded FRAMEWORK_VERSIONS.md documenting core dependencies, versions, base images, framework configurations, dependency management artifacts, notes on variability, and container documentation references for NVIDIA Dynamo. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
/ok to test a76a621 |
WalkthroughAdds a new documentation file, FRAMEWORK_VERSIONS.md, detailing core frameworks and versions, base CUDA images, framework-specific configurations (vLLM, TensorRT-LLM, SGLang), dependency management locations (build scripts, wheels, requirements), notes on version usage, and container documentation references. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
FRAMEWORK_VERSIONS.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
Any way we can generate this automatically? vs. having to manually update? I think that would make our lives easier and could be part of the release process. I think @dagil-nvidia worked on something tangentially related. |
I also think some of this should be covered in a release / support matrix that is floating around somewhere. |
See - Line 7 in d4ff6f0
|
Overview:
add a doc for framework lib versions
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit