Skip to content

Conversation

biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Oct 13, 2025

Overview:

add a doc for framework lib versions

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation
    • Added a centralized reference detailing framework and dependency versions, base container images, framework-specific configurations, and container build/run workflows for NVIDIA Dynamo.
    • Covers core dependencies (e.g., vLLM, TensorRT-LLM, FlashInfer, NIXL, UCX), CUDA versions, integration flags, build locations, and Python requirements.
    • Includes notes on usage variability across frameworks and links to container documentation.
    • Improves clarity and traceability for environment setup and maintenance.

@biswapanda
Copy link
Contributor Author

/ok to test 51d3cb6

@ai-dynamo ai-dynamo deleted a comment from coderabbitai bot Oct 13, 2025
@biswapanda biswapanda force-pushed the bis/vllm-k8s-e2e-test branch from 51d3cb6 to a76a621 Compare October 13, 2025 01:28
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

Walkthrough

Added FRAMEWORK_VERSIONS.md documenting core dependencies, versions, base images, framework configurations, dependency management artifacts, notes on variability, and container documentation references for NVIDIA Dynamo.

Changes

Cohort / File(s) Summary
Documentation
FRAMEWORK_VERSIONS.md
New Markdown doc centralizing dependency versions (vLLM, TensorRT-LLM, FlashInfer, NIXL, UCX), CUDA base images/tags, framework-specific configs, build scripts/requirements, usage notes, and container docs references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I twitch my ears at version notes so grand,
A map of CUDA seas and frameworks planned.
From vLLM to UCX we hop in line,
Tags and builds all neatly now align.
With docs in paw, I bound with cheer—
Dependency trails are crystal clear! 🐇✨

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description uses the required template headings but leaves essential sections such as Details and Where should the reviewer start empty, and the issue reference remains a placeholder. Because of these omissions the pull request description lacks the information reviewers need to understand what was changed and where to focus. Please fill in the Details section with a summary of the actual changes, specify which files or areas reviewers should examine in the Where should the reviewer start section, and replace the placeholder issue number with the correct issue reference.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely indicates that a documentation file for framework library versions is being added, matching the primary purpose of the changeset. It follows the conventional “docs:” prefix and provides enough specificity for reviewers to understand the main change at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90dc758 and 8fe5c37.

📒 Files selected for processing (1)
  • FRAMEWORK_VERSIONS.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@biswapanda biswapanda changed the title doc: add a doc for framework lib versions docs: add a doc for framework lib versions Oct 13, 2025
@github-actions github-actions bot added the docs label Oct 13, 2025
@biswapanda
Copy link
Contributor Author

/ok to test a76a621

@biswapanda biswapanda self-assigned this Oct 13, 2025
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

Walkthrough

Adds a new documentation file, FRAMEWORK_VERSIONS.md, detailing core frameworks and versions, base CUDA images, framework-specific configurations (vLLM, TensorRT-LLM, SGLang), dependency management locations (build scripts, wheels, requirements), notes on version usage, and container documentation references.

Changes

Cohort / File(s) Summary
Documentation
FRAMEWORK_VERSIONS.md
New doc centralizing versions and configs: core dependencies (vLLM v0.11.0, TensorRT-LLM 1.1.0rc5, FlashInfer v0.3.1, NIXL 0.6.0, UCX v1.19.0), base CUDA images (12.8/12.8.1), framework-specific settings (incl. build locations), dependency management paths, notes, and container references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I thump my paws—versions aligned, neat, terse,
CUDA moons shine on our containerverse.
vLLM hops, TensorRT-LLM sprints,
FlashInfer sparkles with speedy hints.
In one burrowed page, the map unfurls—
wheels, scripts, notes for all our whirls.
Carrot-commit: docs guide our worlds. 🥕

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes the required headings but leaves the Details and Where should the reviewer start sections empty and uses a placeholder issue number in Related Issues, so critical information is missing for a thorough review. Please fill in the Details section with a summary of the changes, specify relevant files in the Where should the reviewer start section, and replace the placeholder issue number with the actual GitHub issue to be closed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the main change of adding documentation for framework library versions and follows the concise, imperative style expected for docs updates.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90dc758 and a76a621.

📒 Files selected for processing (1)
  • FRAMEWORK_VERSIONS.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo

@biswapanda biswapanda changed the title docs: add a doc for framework lib versions docs: for framework lib versions Oct 13, 2025
@biswapanda biswapanda changed the title docs: for framework lib versions docs: add a doc for framework lib versions Oct 13, 2025
@alec-flowers
Copy link
Contributor

Any way we can generate this automatically? vs. having to manually update? I think that would make our lives easier and could be part of the release process. I think @dagil-nvidia worked on something tangentially related.

@alec-flowers
Copy link
Contributor

I also think some of this should be covered in a release / support matrix that is floating around somewhere.

@alec-flowers
Copy link
Contributor

See -

# Dynamo Support Matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants