Skip to content

Conversation

biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Oct 13, 2025

Overview:

add gpu details for model recipes

closes DEP-503

Model family Backend Mode GPU Deployment Benchmark
llama-3-70b vllm agg H200
llama-3-70b vllm disagg-multi-node H200
llama-3-70b vllm disagg-single-node H200
DeepSeek-R1 sglang disaggregated H200 🚧
oss-gpt trtllm aggregated GB200

Summary by CodeRabbit

  • Documentation
    • Updated the model recipes table with a new GPU column and populated GPU details across entries (e.g., H200, GB200).
    • Revised table headers and aligned row data to reflect the additional column while retaining existing columns (Model family, Backend, Mode, Deployment, Benchmark).
    • Preserves existing statuses (e.g., DeepSeek-R1) with GPU information added.
    • No functional or behavioral changes.

@biswapanda biswapanda requested review from a team as code owners October 13, 2025 21:12
@github-actions github-actions bot added the docs label Oct 13, 2025
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025

Walkthrough

Adds a new “GPU” column to the model recipes table in recipes/README.md and updates each row to include GPU identifiers (e.g., H200, GB200). Table header and cell alignments are adjusted; other columns remain unchanged.

Changes

Cohort / File(s) Summary
Docs: Model recipes table update
recipes/README.md
Introduced a GPU column to the recipes table, populated GPU values per row (H200 for most, GB200 for oss-gpt). Updated header from Deployment/Benchmark-only to include GPU; retained existing columns and statuses.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nibble notes in README rows,
A GPU column now clearly shows—
H200 here, GB200 there,
Carrots aligned with tidy care.
With twitching ears and markdown cheer,
Our table hops to crystal-clear.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "docs: add gpu details for model recipes" clearly summarizes the primary change of adding GPU details to the model recipes documentation with an appropriate prefix and concise wording.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description includes the required Overview section with a clear statement of intent ("add gpu details for model recipes"), provides Details through a comprehensive table showing the GPU assignments for various model configurations, and properly references the related issue using "closes DEP-503" with the correct action keyword. However, the "Where should the reviewer start?" section is missing from the description template, which would typically call out specific files requiring close review. Despite this omission, the description effectively communicates the scope of changes for this straightforward documentation update.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@biswapanda biswapanda enabled auto-merge (squash) October 13, 2025 21:48
@biswapanda biswapanda self-assigned this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant