-
Notifications
You must be signed in to change notification settings - Fork 822
feat: async encoder cache impl #5676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b03fe26 to
edc7406
Compare
f59361f to
9174ccf
Compare
e64db85 to
86eba89
Compare
9174ccf to
4d01c25
Compare
4d01c25 to
9ec68a5
Compare
WalkthroughThis PR introduces AsyncEncoderCache, an async wrapper around EncoderCacheManager with request coalescing for concurrent access patterns. Multiple concurrent requests for the same key execute only one compute operation while others await the shared result. Changes include the core implementation class, a module initializer for public API export, and comprehensive test coverage. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR
We implemented
AsyncEncoderCachethatEncoderCacheManagerget_or_computefunctionThis will be used in
Test Plan
Summary by CodeRabbit
Release Notes
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.