-
Notifications
You must be signed in to change notification settings - Fork 822
test: streamline Python test structure #5684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9aaa49c to
426ad0a
Compare
WalkthroughThis pull request expands CI coverage for component tests and reorganizes the test directory structure by consolidating Python tests from per-component nested folders into a unified layout under Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tests/README.md`:
- Around line 23-34: Update the README text under the diagram so the bullets and
explanatory table refer explicitly to the new layout shown in the diagram (use
the components/tests/dynamo/<component>/... pattern rather than vague phrasing
like <component>/tests/ or dynamo/tests/); modify the three bullet lines and any
table rows that mention test locations to use the explicit
"components/tests/dynamo/<component>/..." wording and ensure examples and
descriptions match the diagram labels so there is no ambiguity.
426ad0a to
488d327
Compare
488d327 to
c4b0688
Compare
c4b0688 to
d435248
Compare
Prior
Prior to this PR, we have inconsistent guidance on where we place tests
lib/, we havesrcandtestsat the same levelcomponents/, we havetestsinsidesrcThis can create confusion on locating test files.
additionally, the 2nd guidance doesn't bring clarify on how test in nested folder works. e.g. say we have
it's unclear which option should we go for